Removes featurization for remove_accounts_delta_hash#7006
Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom Jul 17, 2025
Merged
Removes featurization for remove_accounts_delta_hash#7006brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo merged 1 commit intoanza-xyz:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7006 +/- ##
=========================================
- Coverage 83.2% 83.2% -0.1%
=========================================
Files 853 853
Lines 375118 375020 -98
=========================================
- Hits 312256 312135 -121
- Misses 62862 62885 +23 🚀 New features to boost your workflow:
|
jstarry
reviewed
Jul 17, 2025
| .feature_set | ||
| .is_active(&feature_set::remove_accounts_delta_hash::id()) | ||
| { | ||
| self.rc.accounts.accounts_db.start_background_hasher(); |
There was a problem hiding this comment.
Should we remove this function since it's no longer used now?
Author
There was a problem hiding this comment.
Yep! There's lots of cleanup to do. I have a big branch where I've been removing everything, then I break that out into smaller PRs that are self contained and easier to review.
| if new_feature_activations.contains(&feature_set::remove_accounts_delta_hash::id()) { | ||
| // If the accounts delta hash has been removed, then we no longer need to compute the | ||
| // AccountHash for modified accounts, and can stop the background account hasher. | ||
| self.rc.accounts.accounts_db.stop_background_hasher(); |
brooksprumo
force-pushed
the
lthash/223/featurization
branch
from
0569b95 to
f00d9af
Compare
roryharr
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
remove_accounts_delta_hashfeature (SIMD-223) has been activated on all public clusters, and its featurization code can be removed.Note, there's lots of additional cleanup to do after this PR too! This one is meant to be the minimum amount of changes to remove uses of
feature_set::remove_accounts_delta_hash.