Skip to content

[clap-v3-utils] Update dependency from zk-token-sdk to zk-sdk#6985

Merged
samkim-crypto merged 6 commits intoanza-xyz:masterfrom
samkim-crypto:clap-v3-utils/zk-sdk
Jul 17, 2025
Merged

[clap-v3-utils] Update dependency from zk-token-sdk to zk-sdk#6985
samkim-crypto merged 6 commits intoanza-xyz:masterfrom
samkim-crypto:clap-v3-utils/zk-sdk

Conversation

@samkim-crypto
Copy link
Copy Markdown

@samkim-crypto samkim-crypto commented Jul 16, 2025

Problem

The clap-v3-utils still relies on the zk-token-sdk, which is deprecated and replaced by zk-sdk.

Summary of Changes

I updated the dependency from zk-token-sdk to zk-sdk. I also realized that most consumers of the clap-v3-utils will not be needing the parsing of ElGamal keys, but they need to have a relatively heavy dependency on zk-sdk and curve25519. I ended up making a separate elgamal feature that can optionally be excluded.

Fixes #

@samkim-crypto samkim-crypto force-pushed the clap-v3-utils/zk-sdk branch from 2ef3487 to d23054d Compare July 16, 2025 02:21
@samkim-crypto samkim-crypto marked this pull request as ready for review July 16, 2025 02:50
@samkim-crypto samkim-crypto requested a review from joncinque July 16, 2025 03:16
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.2%. Comparing base (b3fca5d) to head (7dc34c4).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6985     +/-   ##
=========================================
- Coverage    83.2%    83.2%   -0.1%     
=========================================
  Files         853      853             
  Lines      375517   375517             
=========================================
- Hits       312596   312550     -46     
- Misses      62921    62967     +46     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small things

Comment thread clap-v3-utils/Cargo.toml Outdated
Comment thread clap-v3-utils/Cargo.toml Outdated
name = "solana_clap_v3_utils"

[features]
default = ["elgamal"]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're in the "breaking" phase in v3.0.0, we can potentially make this not a default feature.

Since there aren't too many users, it might be better to not make it default, but I don't feel too strongly about it.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was considering this as well, but was afraid of the breaking change. I removed elgamal from defaut.

@mergify
Copy link
Copy Markdown

mergify Bot commented Jul 17, 2025

For your information, the zk-keygen and zk-sdk directories are
scheduled to be relocated to solana-program/zk-elgamal-proof in a
separate repository. Additionally, the zk-token-sdk directory will
be removed. Please take these upcoming changes into account when
making modifications.

Copy link
Copy Markdown

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@samkim-crypto samkim-crypto merged commit aefebdf into anza-xyz:master Jul 17, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants