[clap-v3-utils] Update dependency from zk-token-sdk to zk-sdk#6985
[clap-v3-utils] Update dependency from zk-token-sdk to zk-sdk#6985samkim-crypto merged 6 commits intoanza-xyz:masterfrom
Conversation
2ef3487 to
d23054d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6985 +/- ##
=========================================
- Coverage 83.2% 83.2% -0.1%
=========================================
Files 853 853
Lines 375517 375517
=========================================
- Hits 312596 312550 -46
- Misses 62921 62967 +46 🚀 New features to boost your workflow:
|
| name = "solana_clap_v3_utils" | ||
|
|
||
| [features] | ||
| default = ["elgamal"] |
There was a problem hiding this comment.
Since we're in the "breaking" phase in v3.0.0, we can potentially make this not a default feature.
Since there aren't too many users, it might be better to not make it default, but I don't feel too strongly about it.
There was a problem hiding this comment.
Yeah I was considering this as well, but was afraid of the breaking change. I removed elgamal from defaut.
Co-authored-by: Jon C <me@jonc.dev>
|
For your information, the |
Problem
The clap-v3-utils still relies on the
zk-token-sdk, which is deprecated and replaced byzk-sdk.Summary of Changes
I updated the dependency from
zk-token-sdktozk-sdk. I also realized that most consumers of the clap-v3-utils will not be needing the parsing of ElGamal keys, but they need to have a relatively heavy dependency on zk-sdk and curve25519. I ended up making a separateelgamalfeature that can optionally be excluded.Fixes #