Downgrade Rust to 1.86.0#6980
Merged
steviez merged 1 commit intoanza-xyz:masterfrom Jul 16, 2025
Merged
Conversation
A performance regression in PohService was observed, and bisect revealed the degradation to start from when we upgraded to Rust 1.87.0 This reverts commit 2361c7d.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6980 +/- ##
=========================================
Coverage ? 83.2%
=========================================
Files ? 853
Lines ? 375917
Branches ? 0
=========================================
Hits ? 312993
Misses ? 62924
Partials ? 0 🚀 New features to boost your workflow:
|
brooksprumo
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A performance regression in PohService was observed, and bisect revealed the degradation to start from when we upgraded to Rust 1.87.0
Summary of Changes
This reverts commit 2361c7d (#6800)
Degradation
The performance regression is visible in
poh-service.total_hash_time_us. Below is a graph of our MNB canaries; these nodes restart on different days of the week with the latest tip-of-master. As we can see, each restart after July 4th shows the degradation.I also confirmed that I saw the degradation when toggling between e92e9a1 and 2361c7d on my dev node:
