Skip to content

gossip: Resolve Rust 1.88 clippy lints and format strings#6972

Merged
steviez merged 3 commits intoanza-xyz:masterfrom
steviez:rust_1.88_gossip
Jul 16, 2025
Merged

gossip: Resolve Rust 1.88 clippy lints and format strings#6972
steviez merged 3 commits intoanza-xyz:masterfrom
steviez:rust_1.88_gossip

Conversation

@steviez
Copy link
Copy Markdown

@steviez steviez commented Jul 15, 2025

Problem

Working towards #6850, broken out from #6854

Summary of Changes

  • Run cargo clippy --fix --tests with Rust 1.88.0 set in rust-toolchain.toml
    • These should only be instances of uninlined_format_args
  • Run cargo fmt with format_strings = true set in rustfmt.toml

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 71.79487% with 11 lines in your changes missing coverage. Please review.

Project coverage is 83.2%. Comparing base (6bc9fb1) to head (9854e13).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6972   +/-   ##
=======================================
  Coverage    83.2%    83.2%           
=======================================
  Files         856      856           
  Lines      376426   376440   +14     
=======================================
+ Hits       313321   313333   +12     
- Misses      63105    63107    +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexpyattaev alexpyattaev requested a review from gregcusack July 15, 2025 13:08
Copy link
Copy Markdown

@gregcusack gregcusack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you!

@steviez steviez merged commit 78d5954 into anza-xyz:master Jul 16, 2025
41 checks passed
@steviez steviez deleted the rust_1.88_gossip branch July 16, 2025 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants