Skip to content

turbine: Resolve Rust 1.88 clippy lints and format strings#6971

Merged
steviez merged 2 commits intoanza-xyz:masterfrom
steviez:rust_1.88_turbine
Jul 15, 2025
Merged

turbine: Resolve Rust 1.88 clippy lints and format strings#6971
steviez merged 2 commits intoanza-xyz:masterfrom
steviez:rust_1.88_turbine

Conversation

@steviez
Copy link
Copy Markdown

@steviez steviez commented Jul 15, 2025

Problem

Working towards #6850, broken out from #6854

Summary of Changes

  • Run cargo clippy --fix --tests with Rust 1.88.0 set in rust-toolchain.toml
    • These should only be instances of uninlined_format_args
  • Run cargo fmt with format_strings = true set in rustfmt.toml

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 49.09091% with 28 lines in your changes missing coverage. Please review.

Project coverage is 83.2%. Comparing base (6bc9fb1) to head (05dd0e4).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6971     +/-   ##
=========================================
- Coverage    83.2%    83.2%   -0.1%     
=========================================
  Files         856      856             
  Lines      376426   376457     +31     
=========================================
- Hits       313321   313290     -31     
- Misses      63105    63167     +62     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@steviez steviez requested a review from alexpyattaev July 15, 2025 16:38
Copy link
Copy Markdown

@alexpyattaev alexpyattaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@steviez steviez merged commit f23c5bc into anza-xyz:master Jul 15, 2025
41 checks passed
@steviez steviez deleted the rust_1.88_turbine branch July 15, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants