Skip to content

ledger: Resolve Rust 1.88 clippy lints and format strings#6964

Merged
steviez merged 3 commits intoanza-xyz:masterfrom
steviez:rust_1.88_ledger
Jul 15, 2025
Merged

ledger: Resolve Rust 1.88 clippy lints and format strings#6964
steviez merged 3 commits intoanza-xyz:masterfrom
steviez:rust_1.88_ledger

Conversation

@steviez
Copy link
Copy Markdown

@steviez steviez commented Jul 14, 2025

Problem

Working towards #6850, broken out from #6854

Summary of Changes

  • Run cargo clippy --fix --tests with Rust 1.88.0 set in rust-toolchain.toml
    • These should only be instances of uninlined_format_args
  • Run cargo fmt with format_strings = true set in rustfmt.toml

Comment thread ledger/src/use_snapshot_archives_at_startup.rs
@steviez steviez force-pushed the rust_1.88_ledger branch from 26898ea to 496a48b Compare July 14, 2025 20:55
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 14, 2025

Codecov Report

❌ Patch coverage is 35.81081% with 95 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.2%. Comparing base (4807a7a) to head (d5966cb).
⚠️ Report is 2932 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6964   +/-   ##
=======================================
  Coverage    83.2%    83.2%           
=======================================
  Files         856      856           
  Lines      376390   376385    -5     
=======================================
+ Hits       313281   313293   +12     
+ Misses      63109    63092   -17     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@steviez steviez requested review from brooksprumo and cpubot July 14, 2025 22:21
brooksprumo
brooksprumo previously approved these changes Jul 14, 2025
Copy link
Copy Markdown

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Copy Markdown

@cpubot cpubot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@steviez steviez merged commit d429f6e into anza-xyz:master Jul 15, 2025
41 checks passed
@steviez steviez deleted the rust_1.88_ledger branch July 15, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants