Skip to content

Tests: use the non-overlapping socket bind API#6886

Merged
alexpyattaev merged 4 commits into
anza-xyz:masterfrom
alexpyattaev:rpc_new_socket_bind
Jul 9, 2025
Merged

Tests: use the non-overlapping socket bind API#6886
alexpyattaev merged 4 commits into
anza-xyz:masterfrom
alexpyattaev:rpc_new_socket_bind

Conversation

@alexpyattaev
Copy link
Copy Markdown

@alexpyattaev alexpyattaev commented Jul 8, 2025

Problem

  • A bunch of tests still relies on either hardcoded ports or bind_to_localhost and bind_to_unspecified. This creates flaky tests in cases where unique port ranges are needed.
  • This is especially noticable in tests such as gossip_ring flaking in CI, as they allocate a lot of ports in a fixed pattern.

Summary of Changes

  • change to use localhost_port_range_for_tests in some of the places.
  • More PRs like this to follow.

@alexpyattaev alexpyattaev changed the title Rpc new socket bind Tests: use the non-overlapping socket bind API Jul 8, 2025
@alexpyattaev alexpyattaev requested review from brooksprumo and yihau July 8, 2025 21:24
@brooksprumo brooksprumo removed their request for review July 8, 2025 21:31
@brooksprumo
Copy link
Copy Markdown

I'm not familiar with these tests, so I'm going to bow out of reviewing. Thanks for taking a look!

@alexpyattaev alexpyattaev marked this pull request as ready for review July 8, 2025 21:51
@alexpyattaev alexpyattaev reopened this Jul 8, 2025
@alexpyattaev alexpyattaev added the CI Pull Request is ready to enter CI label Jul 8, 2025
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Jul 8, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.2%. Comparing base (833b05b) to head (e8f6133).
⚠️ Report is 2946 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6886   +/-   ##
=======================================
  Coverage    83.2%    83.2%           
=======================================
  Files         852      852           
  Lines      376951   376959    +8     
=======================================
+ Hits       313888   313914   +26     
+ Misses      63063    63045   -18     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gregcusack
Copy link
Copy Markdown

lgtm! thank you!

Copy link
Copy Markdown
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@alexpyattaev alexpyattaev merged commit 13337bb into anza-xyz:master Jul 9, 2025
70 of 71 checks passed
@alexpyattaev alexpyattaev deleted the rpc_new_socket_bind branch July 9, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants