Tests: use the non-overlapping socket bind API#6886
Merged
Conversation
|
I'm not familiar with these tests, so I'm going to bow out of reviewing. Thanks for taking a look! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6886 +/- ##
=======================================
Coverage 83.2% 83.2%
=======================================
Files 852 852
Lines 376951 376959 +8
=======================================
+ Hits 313888 313914 +26
+ Misses 63063 63045 -18 🚀 New features to boost your workflow:
|
|
lgtm! thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
bind_to_localhostandbind_to_unspecified. This creates flaky tests in cases where unique port ranges are needed.gossip_ringflaking in CI, as they allocate a lot of ports in a fixed pattern.Summary of Changes
localhost_port_range_for_testsin some of the places.