Replaces scan_index()#6783
Merged
brooksprumo merged 7 commits intoanza-xyz:masterfrom Jul 2, 2025
Merged
Conversation
brooksprumo
commented
Jun 30, 2025
| data_len, | ||
| }, | ||
| }; | ||
| itemizer(info); |
Author
There was a problem hiding this comment.
A subsequent PR can now refactor itemizer(), as it doesn't need to take an IndexInfo anymore. It can be just the fields we need/care about.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6783 +/- ##
=======================================
Coverage 83.3% 83.3%
=======================================
Files 853 853
Lines 378185 378158 -27
=======================================
- Hits 315296 315288 -8
+ Misses 62889 62870 -19 🚀 New features to boost your workflow:
|
roryharr
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
scan_index()function is extraneous. It is/can be implemented in terms of other scan_accounts functions. Havingscan_index()just increases support burden unnecessarily.Related discussion here: #6744 (comment).
Summary of Changes
Replace all call-sites of
scan_index()withscan_accounts_without_data().Note to reviewers: I recommend going through this PR commit-by-commit.