accounts-db: Remove usage of RentCollector#6781
Merged
joncinque merged 1 commit intoanza-xyz:masterfrom Jun 30, 2025
Merged
Conversation
#### Problem The RentCollector type is included in accounts-db types, but it's not actually used for anything. The only place it *is* used is to figure out the number of slots in an epoch, but it looks like that call site only ever passes in `0` anyway, from `RentCollector::default()`. #### Summary of changes Remove RentCollector from types and interfaces in accounts-db.
brooksprumo
approved these changes
Jun 30, 2025
brooksprumo
left a comment
brooksprumo
left a comment
There was a problem hiding this comment.
Thanks for the cleanup! Wasn't really that bad at all.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6781 +/- ##
=======================================
Coverage 83.3% 83.3%
=======================================
Files 853 853
Lines 378185 378167 -18
=======================================
+ Hits 315297 315332 +35
+ Misses 62888 62835 -53 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The RentCollector type is included in accounts-db types, but it's not actually used for anything.
The only place it is used is to figure out the number of slots in an epoch, so instead we pass the epoch explicitly.
Summary of changes
Remove RentCollector from types and interfaces in accounts-db.