Skip to content

Use more canonical imports with io::Result instead of IoResult#6754

Merged
kskalski merged 2 commits intoanza-xyz:masterfrom
kskalski:ks/import_cleanup
Jun 26, 2025
Merged

Use more canonical imports with io::Result instead of IoResult#6754
kskalski merged 2 commits intoanza-xyz:masterfrom
kskalski:ks/import_cleanup

Conversation

@kskalski
Copy link
Copy Markdown

@kskalski kskalski commented Jun 26, 2025

Problem

IoResult use alias is used while a more direct and almost same length reference of io::Result could be used

Summary of Changes

Remove use alias and reference std::io::Result through io import

@kskalski kskalski marked this pull request as ready for review June 26, 2025 17:00
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 26, 2025

Codecov Report

❌ Patch coverage is 85.36585% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.3%. Comparing base (40dcedf) to head (71d522c).
⚠️ Report is 3065 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #6754    +/-   ##
========================================
  Coverage    83.3%    83.3%            
========================================
  Files         852      852            
  Lines      377900   377900            
========================================
+ Hits       314944   315128   +184     
+ Misses      62956    62772   -184     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kskalski kskalski requested a review from brooksprumo June 26, 2025 19:10
Copy link
Copy Markdown

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Thanks for the cleanup!

@kskalski kskalski merged commit b19af55 into anza-xyz:master Jun 26, 2025
28 checks passed
@kskalski kskalski deleted the ks/import_cleanup branch June 26, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants