turbine, bench: move remaining benches to merkle variant#6747
turbine, bench: move remaining benches to merkle variant#67470xbrw merged 7 commits intoanza-xyz:masterfrom
Conversation
| let shredder = Shredder::new(slot, parent_slot, 0, 0).unwrap(); | ||
|
|
||
| let shreds = shredder | ||
| .make_merkle_shreds_from_entries( |
There was a problem hiding this comment.
The way you are calling this it will always make exactly 64 shreds. you should either make sure the number of produced shreds is what num_simulated_shreds calls for, or remove the num_simulated_shreds completely (as it is const anyway and not critical to the purpose of the bench)
|
You need to run |
Fixed. Thank you 🙏 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6747 +/- ##
=======================================
Coverage 83.3% 83.3%
=======================================
Files 852 852
Lines 377993 377993
=======================================
+ Hits 315195 315198 +3
+ Misses 62798 62795 -3 🚀 New features to boost your workflow:
|
Thank you :) |
|
@alexpyattaev is this safe to squash and merge? |
yes, this is good to go |
Problem
Legacy shreds need to go #5982
Summary of Changes
Moved remaining bench to merkle variant. Removed NUM_SIMULATED_SHREDS entirely.