Skip to content

turbine, bench: move cluster_info::broadcast_shreds_bench to merkle shreds#6729

Merged
alexpyattaev merged 2 commits intoanza-xyz:masterfrom
puhtaytow:feat/merkle-bench-0
Jun 26, 2025
Merged

turbine, bench: move cluster_info::broadcast_shreds_bench to merkle shreds#6729
alexpyattaev merged 2 commits intoanza-xyz:masterfrom
puhtaytow:feat/merkle-bench-0

Conversation

@puhtaytow
Copy link
Copy Markdown

@puhtaytow puhtaytow commented Jun 25, 2025

Problem

Legacy shreds need to go #5982

Summary of Changes

Turbine, cluster_info::broadcast_shreds_bench been moved to merkle shreds.

Before / After
test broadcast_shreds_bench ... bench: 5,918.54 ns/iter (+/- 26.64)
test broadcast_shreds_bench ... bench: 5,896.56 ns/iter (+/- 26.39)

@mergify mergify Bot requested a review from a team June 25, 2025 10:35
@puhtaytow puhtaytow marked this pull request as draft June 25, 2025 18:23
@alexpyattaev alexpyattaev added the CI Pull Request is ready to enter CI label Jun 25, 2025
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Jun 25, 2025
@alexpyattaev alexpyattaev self-requested a review June 25, 2025 21:15
@alexpyattaev alexpyattaev marked this pull request as ready for review June 25, 2025 21:19
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.3%. Comparing base (e632b9e) to head (4f62b3e).
⚠️ Report is 3052 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6729     +/-   ##
=========================================
- Coverage    83.3%    83.3%   -0.1%     
=========================================
  Files         852      852             
  Lines      377887   377887             
=========================================
- Hits       315115   315080     -35     
- Misses      62772    62807     +35     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@t-nelson
Copy link
Copy Markdown

@mergify rebase

@mergify
Copy link
Copy Markdown

mergify Bot commented Jun 25, 2025

rebase

✅ Branch has been successfully rebased

@t-nelson t-nelson force-pushed the feat/merkle-bench-0 branch from 77bdc65 to 4f62b3e Compare June 25, 2025 23:03
Copy link
Copy Markdown

@alexpyattaev alexpyattaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@puhtaytow
Copy link
Copy Markdown
Author

LGTM thank you!

Thank you :)

@alexpyattaev alexpyattaev merged commit 1f147b8 into anza-xyz:master Jun 26, 2025
28 checks passed
@puhtaytow puhtaytow deleted the feat/merkle-bench-0 branch June 27, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants