Make use of StoredTransactionError when converting between TransactionError and generated::TransactionError

[steveluscher]

Problem

This is a follow-on from #6434 in which I wrote a newtype to help facilitate serialization/deserialization between TransactionError and generated::TransactionError, and wrote tests for it, but then forgot to actually use it.

Summary of Changes

Replace manual deseriailze/serialize calls in the code that converts TransactionError object for storage in blockstore with calls to into().

[steveluscher]

@joncinque ping for assist (re: #6434 (review))

[joncinque]

This looks correct to me, but I'm not familiar with every place that converts between stored and sdk types.

Have you also looked at StoredTransactionStatusMeta as mentioned in the previous PR? Its status field is currently a Result<(), TransactionError>:

agave/storage-proto/src/lib.rs

Line 179 in d240fe5

pub status: Result<()>,

Based on its usage in blockstore.rs, I'm not sure if it's supposed to be deprecated or only for older versions of the software:

agave/ledger/src/blockstore.rs

Line 2893 in d240fe5

.get_raw_protobuf_or_bincode::<StoredTransactionStatusMeta>(

@steviez do you know what StoredTransactionStatusMeta is for? It looks to be deprecated, so maybe we shouldn't touch it, out of fear of breaking old ledgers. On the other hand, will any modern ledgers ever contain that type anymore?

[steveluscher]

Ping, @steviez?

[github-actions]

This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[anza-team]

😱 New commits were pushed while the automerge label was present.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.3%. Comparing base (d55741a) to head (925aa78).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6704   +/-   ##
=======================================
  Coverage    83.3%    83.3%           
=======================================
  Files         845      845           
  Lines      319955   319951    -4     
=======================================
+ Hits       266772   266778    +6     
+ Misses      53183    53173   -10     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.