ci: add 'NO_INSTALL' flag to ci/rust-version.sh

[yihau]

Problem

there is a confusing message in our build:

the message comes from

agave/ci/rust-version.sh

Line 65 in 557bfcb

echo "$0: Note: ignoring unknown argument: $1" >&2

Summary of Changes

add an option, NO_INSTALL, in the script

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.3%. Comparing base (8b6d80f) to head (a795385).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6663   +/-   ##
=======================================
  Coverage    83.3%    83.3%           
=======================================
  Files         849      849           
  Lines      379469   379469           
=======================================
+ Hits       316234   316266   +32     
+ Misses      63235    63203   -32     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[willhickey]

Why does this code block even run, since ci/docker/env.sh sources this script with no args?

[yihau]

yeah… maybe I should extract the env from the actual logic 🤔. actually, I’m in a bit of a dilemma. we’ve already advertised using ci/rust-version.sh to install https://github.com/anza-xyz/agave/blob/master/README.md?plain=1#L28. also, I think we’ve gotten used to updating the rust stable/nightly version in this file. splitting it might open a long thread 🙈 so I decide to just introduce a no harm env to control the flow

[willhickey]

Yeah I'm fine with merging this as a workaround.

But I really don't see how this it's printing the ignoring unknown argument warning in this case, since that whole code block should be skipped if -z $1. Do you understand what's happening to make it print the warning?

[yihau]

afaik, when we source a file, it shares the same context. if we don’t reset the args, they will be inherited by the script.

[willhickey]

Ah yeah I just reproduced this locally... I didn't know sourced scripts picked up the args from the parent.