Remove must_replace parameter from add_builtin_account#662
Merged
LucasSte merged 1 commit intoanza-xyz:masterfrom Apr 8, 2024
Merged
Remove must_replace parameter from add_builtin_account#662LucasSte merged 1 commit intoanza-xyz:masterfrom
must_replace parameter from add_builtin_account#662LucasSte merged 1 commit intoanza-xyz:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #662 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 851 851
Lines 230165 230136 -29
=======================================
- Hits 188464 188446 -18
+ Misses 41701 41690 -11 |
Lichtso
approved these changes
Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
must_replaceparameter ofadd_builtin_accountis not necessary and can be cleaned up to facilitate movingadd_builtinto the SVM crate.See also #547 (comment)
Summary of Changes
I removed the parameter and fixed all the usages.