Skip to content

Multihoming: Udp verify reachability#6611

Merged
gregcusack merged 1 commit intoanza-xyz:masterfrom
gregcusack:udp-verify-reachability-multihomed
Jun 17, 2025
Merged

Multihoming: Udp verify reachability#6611
gregcusack merged 1 commit intoanza-xyz:masterfrom
gregcusack:udp-verify-reachability-multihomed

Conversation

@gregcusack
Copy link
Copy Markdown

Problem

verify_all_reachable_udp() assumes all sockets are bound to the same IP, but with multihoming, they may not be

Summary of Changes

Remove assumption that sockets are bound to the same IP make sure all sockets on all IPs are reachable

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.8%. Comparing base (ec3872b) to head (a65ba0c).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6611   +/-   ##
=======================================
  Coverage    82.8%    82.8%           
=======================================
  Files         849      849           
  Lines      379047   379035   -12     
=======================================
+ Hits       313903   313926   +23     
+ Misses      65144    65109   -35     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gregcusack gregcusack requested a review from alexpyattaev June 17, 2025 01:57
Copy link
Copy Markdown

@alexpyattaev alexpyattaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing this!

@gregcusack gregcusack merged commit f9a04f7 into anza-xyz:master Jun 17, 2025
28 checks passed
@gregcusack gregcusack deleted the udp-verify-reachability-multihomed branch June 17, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants