cli: Full snapshot interval doesn't need to be a multiple of the incremental#6595
Merged
brooksprumo merged 2 commits intoanza-xyz:masterfrom Jun 16, 2025
Merged
cli: Full snapshot interval doesn't need to be a multiple of the incremental#6595brooksprumo merged 2 commits intoanza-xyz:masterfrom
brooksprumo merged 2 commits intoanza-xyz:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6595 +/- ##
=======================================
Coverage 82.8% 82.8%
=======================================
Files 849 849
Lines 379047 379047
=======================================
+ Hits 313966 313973 +7
+ Misses 65081 65074 -7 🚀 New features to boost your workflow:
|
jstarry
reviewed
Jun 16, 2025
Comment on lines
+447
to
+448
| "Number of slots between generating full snapshots. \ | ||
| Only used when incremental snapshots are enabled.", |
There was a problem hiding this comment.
Must it still be greater or equal to the incremental snapshot interval?
Author
There was a problem hiding this comment.
Yes. Must be strictly greater than. Want me to add that?
jstarry
approved these changes
Jun 16, 2025
steviez
reviewed
Jun 16, 2025
steviez
left a comment
steviez
left a comment
There was a problem hiding this comment.
Glad you didn't wait for me to merge, but in clearing my queue, this LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since PR #5519, the cli help for
--full-snapshot-interval-slotsis wrong: the full snapshot interval does not need to be a multiple of the incremental snapshot interval.