send-transaction-service: use message hash and blockhash to look up committed tx status

[jstarry]

Problem

The STS (used by the send transaction RPC method) uses a slow signature lookup approach to determine whether a transaction has been committed or not

Summary of Changes

• Use tx blockhash to lookup committed transaction status faster (no need to scan through all blockhash keys in the status cache anymore)
• Switch to using message hash for committed transaction status lookups

Fixes #

[mergify]

If this PR represents a change to the public RPC API:

1. Make sure it includes a complementary update to rpc-client/ (example)
2. Open a follow-up PR to update the JavaScript client @solana/kit (example)

Thank you for keeping the RPC clients in sync with the server API @jstarry.

[steveluscher]

…uses a slow signature lookup approach…

This is because it looks in all the blockhash partitions, right, instead of choosing the right one straight away?

[steveluscher]

What if we skated where the puck was going here, and instead returned a boolean to say if the thing errored or not. This envisions a future where BankStatusCache no longer contains TransactionResult, but at most an indication of whether a seen transaction was a success or failure.

pub fn get_committed_transaction_status_and_slot(
    &self,
    message_hash: &Hash,
    transaction_blockhash: &Hash,
) -> Option<(Slot, boolean)> {
    let rcache = self.status_cache.read().unwrap();
    rcache
        .get_status(message_hash, transaction_blockhash, &self.ancestors)
        .map(|(slot, transaction_result)| (slot, transaction_result.is_ok())) 
}

[jstarry]

Yeah sounds great. Changed in 0f5b099

[jstarry]

This is because it looks in all the blockhash partitions, right, instead of choosing the right one straight away?

Yes, that's correct. I updated the title and description to say that explicitly

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 97.69231% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.8%. Comparing base (69e749e) to head (0f5b099).
Report is 17 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##           master    #6585     +/-   ##
=========================================
- Coverage    82.8%    82.8%   -0.1%     
=========================================
  Files         849      849             
  Lines      379196   379301    +105     
=========================================
+ Hits       314029   314113     +84     
- Misses      65167    65188     +21     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[steveluscher]