Skip to content

Add a TODO for "solBnkNewFlds" threadpool#6584

Merged
HaoranYi merged 1 commit intoanza-xyz:masterfrom
HaoranYi:to_do
Jun 16, 2025
Merged

Add a TODO for "solBnkNewFlds" threadpool#6584
HaoranYi merged 1 commit intoanza-xyz:masterfrom
HaoranYi:to_do

Conversation

@HaoranYi
Copy link
Copy Markdown

@HaoranYi HaoranYi commented Jun 13, 2025

Problem

Add a TODO commentsfor "solBnkNewFlds" threadpool optimization.

We can do this after lt-hash feature is active.

Summary of Changes

Fixes #

@HaoranYi HaoranYi requested a review from brooksprumo June 13, 2025 20:56
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.8%. Comparing base (ccdcdbe) to head (ab62f7e).

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6584     +/-   ##
=========================================
- Coverage    82.8%    82.8%   -0.1%     
=========================================
  Files         849      849             
  Lines      379032   379039      +7     
=========================================
- Hits       313911   313897     -14     
- Misses      65121    65142     +21     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm usually against adding TODOs into the repo. But we're close to activating the lt hash features on all clusters, and then I can clean up the featurization code, which'll then allow addressing the TODO.

@HaoranYi HaoranYi merged commit 5d39390 into anza-xyz:master Jun 16, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants