Skip to content

v2.3: Remove redundant BufReaders for decompressing tar archives (backport of #6317)#6453

Merged
brooksprumo merged 1 commit intov2.3from
mergify/bp/v2.3/pr-6317
Jun 9, 2025
Merged

v2.3: Remove redundant BufReaders for decompressing tar archives (backport of #6317)#6453
brooksprumo merged 1 commit intov2.3from
mergify/bp/v2.3/pr-6317

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented Jun 6, 2025

Problem

ZSTD Decoder::new creates buf reader with tuned size already, other decoders handle buffering too:

In those cases wrapping reader with BufReader is counter-productive or unnecessary (bzip2 provides both bufread and read decoders)

Summary of Changes

Remove redundant BufReaders for decompressing tar archives when underlying decompressor is already doing buffering.


This is an automatic backport of pull request #6317 done by [Mergify](https://mergify.com).

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.8%. Comparing base (de54ce0) to head (8d1fdd8).
Report is 1 commits behind head on v2.3.

Additional details and impacted files
@@            Coverage Diff            @@
##             v2.3    #6453     +/-   ##
=========================================
- Coverage    82.8%    82.8%   -0.1%     
=========================================
  Files         848      848             
  Lines      379479   379477      -2     
=========================================
- Hits       314550   314503     -47     
- Misses      64929    64974     +45     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brooksprumo
Copy link
Copy Markdown

@Mergifyio rebase

* perf: remove redundant BufReaders for decompressing tar archives

* Format

* Switch bzip2 decoder to read

(cherry picked from commit da1b789)
@mergify
Copy link
Copy Markdown
Author

mergify Bot commented Jun 9, 2025

rebase

✅ Branch has been successfully rebased

@brooksprumo brooksprumo force-pushed the mergify/bp/v2.3/pr-6317 branch from 61f1608 to 8d1fdd8 Compare June 9, 2025 15:42
@brooksprumo brooksprumo requested a review from kskalski June 9, 2025 16:39
@brooksprumo brooksprumo requested a review from a team June 9, 2025 18:07
@brooksprumo brooksprumo merged commit 5ea6fd5 into v2.3 Jun 9, 2025
46 checks passed
@brooksprumo brooksprumo deleted the mergify/bp/v2.3/pr-6317 branch June 9, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants