Skip to content

Fix - Reformulates code comment in natural language#6337

Merged
Lichtso merged 1 commit into
anza-xyz:masterfrom
Lichtso:fix/comment_in_extend_program_checked
Jun 4, 2025
Merged

Fix - Reformulates code comment in natural language#6337
Lichtso merged 1 commit into
anza-xyz:masterfrom
Lichtso:fix/comment_in_extend_program_checked

Conversation

@Lichtso
Copy link
Copy Markdown

@Lichtso Lichtso commented May 28, 2025

Problem

See #6217 (comment).

Summary of Changes

Reformulates the code comment in question as natural language.

@Lichtso Lichtso requested a review from t-nelson May 28, 2025 07:17
@Lichtso Lichtso requested a review from a team as a code owner May 28, 2025 07:17
@mergify
Copy link
Copy Markdown

mergify Bot commented May 28, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.8%. Comparing base (4f4b819) to head (d4f468c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6337   +/-   ##
=======================================
  Coverage    82.8%    82.8%           
=======================================
  Files         846      846           
  Lines      378215   378215           
=======================================
+ Hits       313314   313327   +13     
+ Misses      64901    64888   -13     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread programs/bpf_loader/src/lib.rs Outdated
@Lichtso Lichtso force-pushed the fix/comment_in_extend_program_checked branch from d4f468c to 89d3d20 Compare May 28, 2025 15:33
Copy link
Copy Markdown

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect! thanks!

@t-nelson t-nelson added the v2.2 label May 28, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented May 28, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@Lichtso Lichtso merged commit 0c1d60d into anza-xyz:master Jun 4, 2025
48 checks passed
@Lichtso Lichtso deleted the fix/comment_in_extend_program_checked branch June 4, 2025 06:52
mergify Bot pushed a commit that referenced this pull request Jun 4, 2025
Reformulates code comment in natural language.

(cherry picked from commit 0c1d60d)

# Conflicts:
#	programs/bpf_loader/src/lib.rs
Lichtso added a commit that referenced this pull request Jun 6, 2025
Reformulates code comment in natural language.

(cherry picked from commit 0c1d60d)
t-nelson pushed a commit that referenced this pull request Jun 10, 2025
Reformulates code comment in natural language.

(cherry picked from commit 0c1d60d)
Lichtso added a commit that referenced this pull request Jun 11, 2025
…#6337) (#6405)

Fix - Reformulates code comment in natural language (#6337)

Reformulates code comment in natural language.

(cherry picked from commit 0c1d60d)

Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net>
mircea-c added a commit to mircea-c/agave that referenced this pull request Jun 12, 2025
Reformulates code comment in natural language.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants