vote: move benchmarks to bencher 0.1.5#6090
Merged
alexpyattaev merged 5 commits intoanza-xyz:masterfrom Jul 15, 2025
Merged
Conversation
|
@alessandrod, do you agree that this is an appropriate way of getting rid of nightly benches? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6090 +/- ##
=========================================
- Coverage 83.2% 83.2% -0.1%
=========================================
Files 856 856
Lines 376426 376426
=========================================
- Hits 313321 313272 -49
- Misses 63105 63154 +49 🚀 New features to boost your workflow:
|
alexpyattaev
approved these changes
Jul 15, 2025
alexpyattaev
left a comment
There was a problem hiding this comment.
LGTM based on discussion in https://discord.com/channels/428295358100013066/439194979856809985/1392071885902057502
kskalski
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Our benchmarking setup relies on nightly compiler which is not what we use for actual builds of agave. Using the same compiler (stable) for releases and benches would be preferable #5931
Summary of Changes
Moved benchmarks to bencher 0.1.5.