Skip to content

vote: move benchmarks to bencher 0.1.5#6090

Merged
alexpyattaev merged 5 commits intoanza-xyz:masterfrom
puhtaytow:feat/vote-bench-0
Jul 15, 2025
Merged

vote: move benchmarks to bencher 0.1.5#6090
alexpyattaev merged 5 commits intoanza-xyz:masterfrom
puhtaytow:feat/vote-bench-0

Conversation

@puhtaytow
Copy link
Copy Markdown

@puhtaytow puhtaytow commented May 4, 2025

Problem

Our benchmarking setup relies on nightly compiler which is not what we use for actual builds of agave. Using the same compiler (stable) for releases and benches would be preferable #5931

Summary of Changes

Moved benchmarks to bencher 0.1.5.

@mergify mergify Bot requested a review from a team May 4, 2025 09:26
@puhtaytow puhtaytow changed the title vote: swap bencher by criterion vote: move benchmarks to bencher 0.1.5 Jul 15, 2025
@puhtaytow puhtaytow marked this pull request as draft July 15, 2025 14:21
@puhtaytow puhtaytow marked this pull request as ready for review July 15, 2025 14:34
@alexpyattaev
Copy link
Copy Markdown

@alessandrod, do you agree that this is an appropriate way of getting rid of nightly benches?

@alexpyattaev alexpyattaev added the CI Pull Request is ready to enter CI label Jul 15, 2025
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Jul 15, 2025
@alexpyattaev alexpyattaev added the CI Pull Request is ready to enter CI label Jul 15, 2025
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Jul 15, 2025
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.2%. Comparing base (6bc9fb1) to head (87c2470).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6090     +/-   ##
=========================================
- Coverage    83.2%    83.2%   -0.1%     
=========================================
  Files         856      856             
  Lines      376426   376426             
=========================================
- Hits       313321   313272     -49     
- Misses      63105    63154     +49     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexpyattaev alexpyattaev requested a review from kskalski July 15, 2025 19:38
Copy link
Copy Markdown

@alexpyattaev alexpyattaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexpyattaev alexpyattaev merged commit 97f050d into anza-xyz:master Jul 15, 2025
54 checks passed
@puhtaytow puhtaytow deleted the feat/vote-bench-0 branch July 16, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants