v1.18: Fix - FailedVerification and Closed tombstones (backport of #419)

[mergify]

Problems

1. TransactionBatchProcessor::load_program_with_pubkey() returns LoadedProgramType::FailedVerification even for accounts which never got to the verifier (because they are empty or buffers for example) which should be marked as LoadedProgramType::Closed instead. LoadedProgramType::FailedVerification should only be used if there is a chance a program gets valid again in the recompilation phase when the feature set and environment changes.

2. In the tests we currently check that loading non existent accounts results in LoadedProgramType::Closed entries. This however can not happen in integration because we only attempt to load accounts which have a loader as a owner, thus these account must exist. The situation is similar to when we tested LoadedProgramType::FailedVerification existing in the global cache (which can't happen either) and it led to confusion and wasted efforts.

Summary of Changes

• Replace ProgramAccountLoadResult::AccountNotFound by None
• Have TransactionBatchProcessor::load_program_accounts() only return ProgramAccountLoadResult::InvalidAccountData in other error cases
• Have TransactionBatchProcessor::load_program_with_pubkey() return LoadedProgramType::Closed when TransactionBatchProcessor::load_program_accounts() returned ProgramAccountLoadResult::InvalidAccountData
• Panic in replenish_program_cache() when attempting to load a nonexistent account, and add a test for that

test_bpf_loader_upgradeable_deploy_with_max_len():

• Replace mock_process_instruction() by a proper message send
• Tests the invocation of an empty account before a program is deployed there
• Tests the invocation of a buffer account before it is used to deploy a program

  ---

  This is an automatic backport of pull request Fix - FailedVerification and Closed tombstones #419 done by Mergify.

[mergify]

Cherry-pick of 55c05c5 has failed:

On branch mergify/bp/v1.18/pr-419
Your branch is up to date with 'origin/v1.18'.

You are currently cherry-picking commit 55c05c5ea5.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   ledger-tool/src/program.rs
	both modified:   program-runtime/src/loaded_programs.rs
	both modified:   runtime/src/bank.rs
	both modified:   runtime/src/bank/tests.rs
	deleted by us:   svm/src/transaction_processor.rs

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 81.81818% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 81.5%. Comparing base (7b8ed3b) to head (37726cb).

Additional details and impacted files

@@           Coverage Diff           @@
##            v1.18     #605   +/-   ##
=======================================
  Coverage    81.5%    81.5%           
=======================================
  Files         827      827           
  Lines      224833   224852   +19     
=======================================
+ Hits       183453   183474   +21     
+ Misses      41380    41378    -2