svm tests: enable features by default#6043
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6043 +/- ##
=======================================
Coverage 82.7% 82.7%
=======================================
Files 841 841
Lines 378317 378323 +6
=======================================
+ Hits 313134 313171 +37
+ Misses 65183 65152 -31 🚀 New features to boost your workflow:
|
LucasSte
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
svm integration tests treat features as opt-in rather than opt-out. this is dangerous: a dev can add a feature, pass tests, enable it on all networks, and only discover it fails tests after they go to remove the feature gate
Summary of Changes
reverse this so tests must disable rather than enable features