Skip to content

svm tests: enable features by default#6043

Merged
2501babe merged 1 commit into
anza-xyz:masterfrom
2501babe:20250430_svmintegfeatures
May 5, 2025
Merged

svm tests: enable features by default#6043
2501babe merged 1 commit into
anza-xyz:masterfrom
2501babe:20250430_svmintegfeatures

Conversation

@2501babe
Copy link
Copy Markdown
Member

@2501babe 2501babe commented Apr 30, 2025

Problem

svm integration tests treat features as opt-in rather than opt-out. this is dangerous: a dev can add a feature, pass tests, enable it on all networks, and only discover it fails tests after they go to remove the feature gate

Summary of Changes

reverse this so tests must disable rather than enable features

@2501babe 2501babe self-assigned this Apr 30, 2025
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.7%. Comparing base (ebae35e) to head (86b8360).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6043   +/-   ##
=======================================
  Coverage    82.7%    82.7%           
=======================================
  Files         841      841           
  Lines      378317   378323    +6     
=======================================
+ Hits       313134   313171   +37     
+ Misses      65183    65152   -31     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@2501babe 2501babe marked this pull request as ready for review April 30, 2025 19:07
@2501babe 2501babe requested a review from a team as a code owner April 30, 2025 19:07
@2501babe 2501babe requested a review from LucasSte April 30, 2025 19:07
@2501babe 2501babe merged commit 629107d into anza-xyz:master May 5, 2025
47 checks passed
@2501babe 2501babe deleted the 20250430_svmintegfeatures branch May 5, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants