clippy: allow result_large_err in some places

bench-tps/src/bench.rs

@@ -1111,6 +1111,7 @@ fn compute_and_report_stats(
     );
 }
 
+#[allow(clippy::result_large_err)]
 pub fn generate_and_fund_keypairs<T: 'static + TpsClient + Send + Sync + ?Sized>(
     client: Arc<T>,
     funding_key: &Keypair,
@@ -1140,6 +1141,7 @@ pub fn generate_and_fund_keypairs<T: 'static + TpsClient + Send + Sync + ?Sized>
     Ok(keypairs)
 }
 
+#[allow(clippy::result_large_err)]
 pub fn fund_keypairs<T: 'static + TpsClient + Send + Sync + ?Sized>(
     client: Arc<T>,
     funding_key: &Keypair,

bench-tps/src/rpc_with_retry_utils.rs

@@ -10,6 +10,7 @@ use {
 const NUM_RETRY: u64 = 5;
 const RETRY_EVERY_MS: u64 = 4 * DEFAULT_MS_PER_SLOT;
 
+#[allow(clippy::result_large_err)]
 fn call_rpc_with_retry<Func, Data>(f: Func, retry_warning: &str) -> TpsClientResult<Data>
 where
     Func: Fn() -> TpsClientResult<Data>,
@@ -32,6 +33,7 @@ where
     }
 }
 
+#[allow(clippy::result_large_err)]
 pub(crate) fn get_slot_with_retry<Client>(
     client: &Arc<Client>,
     commitment: CommitmentConfig,
@@ -45,6 +47,7 @@ where
     )
 }
 
+#[allow(clippy::result_large_err)]
 pub(crate) fn get_blocks_with_retry<Client>(
     client: &Arc<Client>,
     start_slot: Slot,

cli/src/address_lookup_table.rs

@@ -248,6 +248,7 @@ impl AddressLookupTableSubCommands for App<'_, '_> {
     }
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_address_lookup_table_subcommand(
     matches: &ArgMatches<'_>,
     default_signer: &DefaultSigner,

cli/src/checks.rs

@@ -5,6 +5,7 @@ use {
     solana_rpc_client_api::client_error::Result as ClientResult,
 };
 
+#[allow(clippy::result_large_err)]
 pub fn check_account_for_fee(
     rpc_client: &RpcClient,
     account_pubkey: &Pubkey,
@@ -13,6 +14,7 @@ pub fn check_account_for_fee(
     check_account_for_multiple_fees(rpc_client, account_pubkey, &[message])
 }
 
+#[allow(clippy::result_large_err)]
 pub fn check_account_for_fee_with_commitment(
     rpc_client: &RpcClient,
     account_pubkey: &Pubkey,
@@ -27,6 +29,7 @@ pub fn check_account_for_fee_with_commitment(
     )
 }
 
+#[allow(clippy::result_large_err)]
 pub fn check_account_for_multiple_fees(
     rpc_client: &RpcClient,
     account_pubkey: &Pubkey,
@@ -40,6 +43,7 @@ pub fn check_account_for_multiple_fees(
     )
 }
 
+#[allow(clippy::result_large_err)]
 pub fn check_account_for_multiple_fees_with_commitment(
     rpc_client: &RpcClient,
     account_pubkey: &Pubkey,
@@ -55,6 +59,7 @@ pub fn check_account_for_multiple_fees_with_commitment(
     )
 }
 
+#[allow(clippy::result_large_err)]
 pub fn check_account_for_spend_multiple_fees_with_commitment(
     rpc_client: &RpcClient,
     account_pubkey: &Pubkey,
@@ -72,6 +77,7 @@ pub fn check_account_for_spend_multiple_fees_with_commitment(
     )
 }
 
+#[allow(clippy::result_large_err)]
 pub fn check_account_for_spend_and_fee_with_commitment(
     rpc_client: &RpcClient,
     account_pubkey: &Pubkey,
@@ -110,6 +116,7 @@ pub fn check_account_for_spend_and_fee_with_commitment(
     Ok(())
 }
 
+#[allow(clippy::result_large_err)]
 pub fn get_fee_for_messages(
     rpc_client: &RpcClient,
     messages: &[&Message],
@@ -122,6 +129,7 @@ pub fn get_fee_for_messages(
         .sum())
 }
 
+#[allow(clippy::result_large_err)]
 pub fn check_account_for_balance(
     rpc_client: &RpcClient,
     account_pubkey: &Pubkey,
@@ -135,6 +143,7 @@ pub fn check_account_for_balance(
     )
 }
 
+#[allow(clippy::result_large_err)]
 pub fn check_account_for_balance_with_commitment(
     rpc_client: &RpcClient,
     account_pubkey: &Pubkey,
@@ -150,6 +159,7 @@ pub fn check_account_for_balance_with_commitment(
     Ok(false)
 }
 
+#[allow(clippy::result_large_err)]
 pub fn check_unique_pubkeys(
     pubkey0: (&Pubkey, String),
     pubkey1: (&Pubkey, String),

cli/src/cli.rs

@@ -1718,6 +1718,7 @@ pub fn process_command(config: &CliConfig) -> ProcessResult {
     }
 }
 
+#[allow(clippy::result_large_err)]
 pub fn request_and_confirm_airdrop(
     rpc_client: &RpcClient,
     config: &CliConfig,

cli/src/cluster_query.rs

@@ -511,6 +511,7 @@ impl ClusterQuerySubCommands for App<'_, '_> {
     }
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_catchup(
     matches: &ArgMatches<'_>,
     wallet_manager: &mut Option<Rc<RemoteWalletManager>>,
@@ -542,6 +543,7 @@ pub fn parse_catchup(
     }))
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_cluster_ping(
     matches: &ArgMatches<'_>,
     default_signer: &DefaultSigner,
@@ -570,13 +572,15 @@ pub fn parse_cluster_ping(
     })
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_get_block(matches: &ArgMatches<'_>) -> Result<CliCommandInfo, CliError> {
     let slot = value_of(matches, "slot");
     Ok(CliCommandInfo::without_signers(CliCommand::GetBlock {
         slot,
     }))
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_get_recent_prioritization_fees(
     matches: &ArgMatches<'_>,
 ) -> Result<CliCommandInfo, CliError> {
@@ -590,29 +594,35 @@ pub fn parse_get_recent_prioritization_fees(
     ))
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_get_block_time(matches: &ArgMatches<'_>) -> Result<CliCommandInfo, CliError> {
     let slot = value_of(matches, "slot");
     Ok(CliCommandInfo::without_signers(CliCommand::GetBlockTime {
         slot,
     }))
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_get_epoch(_matches: &ArgMatches<'_>) -> Result<CliCommandInfo, CliError> {
     Ok(CliCommandInfo::without_signers(CliCommand::GetEpoch))
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_get_epoch_info(_matches: &ArgMatches<'_>) -> Result<CliCommandInfo, CliError> {
     Ok(CliCommandInfo::without_signers(CliCommand::GetEpochInfo))
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_get_slot(_matches: &ArgMatches<'_>) -> Result<CliCommandInfo, CliError> {
     Ok(CliCommandInfo::without_signers(CliCommand::GetSlot))
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_get_block_height(_matches: &ArgMatches<'_>) -> Result<CliCommandInfo, CliError> {
     Ok(CliCommandInfo::without_signers(CliCommand::GetBlockHeight))
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_largest_accounts(matches: &ArgMatches<'_>) -> Result<CliCommandInfo, CliError> {
     let filter = if matches.is_present("circulating") {
         Some(RpcLargestAccountsFilter::Circulating)
@@ -626,23 +636,27 @@ pub fn parse_largest_accounts(matches: &ArgMatches<'_>) -> Result<CliCommandInfo
     ))
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_supply(matches: &ArgMatches<'_>) -> Result<CliCommandInfo, CliError> {
     let print_accounts = matches.is_present("print_accounts");
     Ok(CliCommandInfo::without_signers(CliCommand::Supply {
         print_accounts,
     }))
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_total_supply(_matches: &ArgMatches<'_>) -> Result<CliCommandInfo, CliError> {
     Ok(CliCommandInfo::without_signers(CliCommand::TotalSupply))
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_get_transaction_count(_matches: &ArgMatches<'_>) -> Result<CliCommandInfo, CliError> {
     Ok(CliCommandInfo::without_signers(
         CliCommand::GetTransactionCount,
     ))
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_show_stakes(
     matches: &ArgMatches<'_>,
     wallet_manager: &mut Option<Rc<RemoteWalletManager>>,
@@ -658,6 +672,7 @@ pub fn parse_show_stakes(
     }))
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_show_validators(matches: &ArgMatches<'_>) -> Result<CliCommandInfo, CliError> {
     let use_lamports_unit = matches.is_present("lamports");
     let number_validators = matches.is_present("number");
@@ -691,6 +706,7 @@ pub fn parse_show_validators(matches: &ArgMatches<'_>) -> Result<CliCommandInfo,
     ))
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_transaction_history(
     matches: &ArgMatches<'_>,
     wallet_manager: &mut Option<Rc<RemoteWalletManager>>,
@@ -972,6 +988,7 @@ pub fn process_first_available_block(rpc_client: &RpcClient) -> ProcessResult {
     Ok(format!("{first_available_block}"))
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_leader_schedule(matches: &ArgMatches<'_>) -> Result<CliCommandInfo, CliError> {
     let epoch = value_of(matches, "epoch");
     Ok(CliCommandInfo::without_signers(
@@ -1195,6 +1212,7 @@ pub fn process_get_block_height(rpc_client: &RpcClient, _config: &CliConfig) ->
     Ok(block_height.to_string())
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_show_block_production(matches: &ArgMatches<'_>) -> Result<CliCommandInfo, CliError> {
     let epoch = value_t!(matches, "epoch", Epoch).ok();
     let slot_limit = value_t!(matches, "slot_limit", u64).ok();
@@ -1643,6 +1661,7 @@ pub fn process_ping(
     Ok(config.output_format.formatted_string(&cli_ping))
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_logs(
     matches: &ArgMatches<'_>,
     wallet_manager: &mut Option<Rc<RemoteWalletManager>>,

cli/src/feature.rs

@@ -512,6 +512,7 @@ impl FeatureSubCommands for App<'_, '_> {
     }
 }
 
+#[allow(clippy::result_large_err)]
 fn known_feature(feature: &Pubkey) -> Result<(), CliError> {
     if FEATURE_NAMES.contains_key(feature) {
         Ok(())
@@ -522,6 +523,7 @@ fn known_feature(feature: &Pubkey) -> Result<(), CliError> {
     }
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_feature_subcommand(
     matches: &ArgMatches<'_>,
     default_signer: &DefaultSigner,
@@ -678,6 +680,7 @@ impl ClusterInfoStats {
     }
 }
 
+#[allow(clippy::result_large_err)]
 fn cluster_info_stats(rpc_client: &RpcClient) -> Result<ClusterInfoStats, ClientError> {
     #[derive(Default)]
     struct StatsEntry {
@@ -776,6 +779,7 @@ fn cluster_info_stats(rpc_client: &RpcClient) -> Result<ClusterInfoStats, Client
 }
 
 // Feature activation is only allowed when 95% of the active stake is on the current feature set
+#[allow(clippy::result_large_err)]
 fn feature_activation_allowed(
     rpc_client: &RpcClient,
     quiet: bool,
@@ -901,6 +905,7 @@ pub fn get_feature_is_active(
         .map(|status| matches!(status, Some(CliFeatureStatus::Active(_))))
 }
 
+#[allow(clippy::result_large_err)]
 pub fn get_feature_activation_epoch(
     rpc_client: &RpcClient,
     feature_id: &Pubkey,

cli/src/inflation.rs

@@ -54,6 +54,7 @@ impl InflationSubCommands for App<'_, '_> {
     }
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_inflation_subcommand(
     matches: &ArgMatches<'_>,
     _default_signer: &DefaultSigner,

cli/src/nonce.rs

@@ -204,6 +204,7 @@ impl NonceSubCommands for App<'_, '_> {
     }
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_authorize_nonce_account(
     matches: &ArgMatches<'_>,
     default_signer: &DefaultSigner,
@@ -235,6 +236,7 @@ pub fn parse_authorize_nonce_account(
     })
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_nonce_create_account(
     matches: &ArgMatches<'_>,
     default_signer: &DefaultSigner,
@@ -268,6 +270,7 @@ pub fn parse_nonce_create_account(
     })
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_get_nonce(
     matches: &ArgMatches<'_>,
     wallet_manager: &mut Option<Rc<RemoteWalletManager>>,
@@ -280,6 +283,7 @@ pub fn parse_get_nonce(
     )))
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_new_nonce(
     matches: &ArgMatches<'_>,
     default_signer: &DefaultSigner,
@@ -309,6 +313,7 @@ pub fn parse_new_nonce(
     })
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_show_nonce_account(
     matches: &ArgMatches<'_>,
     wallet_manager: &mut Option<Rc<RemoteWalletManager>>,
@@ -325,6 +330,7 @@ pub fn parse_show_nonce_account(
     ))
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_withdraw_from_nonce_account(
     matches: &ArgMatches<'_>,
     default_signer: &DefaultSigner,
@@ -359,6 +365,7 @@ pub fn parse_withdraw_from_nonce_account(
     })
 }
 
+#[allow(clippy::result_large_err)]
 pub(crate) fn parse_upgrade_nonce_account(
     matches: &ArgMatches<'_>,
 ) -> Result<CliCommandInfo, CliError> {
@@ -376,6 +383,7 @@ pub(crate) fn parse_upgrade_nonce_account(
 }
 
 /// Check if a nonce account is initialized with the given authority and hash
+#[allow(clippy::result_large_err)]
 pub fn check_nonce_account(
     nonce_account: &Account,
     nonce_authority: &Pubkey,

cli/src/program.rs

@@ -679,6 +679,7 @@ impl ProgramSubCommands for App<'_, '_> {
     }
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_program_subcommand(
     matches: &ArgMatches<'_>,
     default_signer: &DefaultSigner,

cli/src/program_v4.rs

@@ -351,6 +351,7 @@ impl ProgramV4SubCommands for App<'_, '_> {
     }
 }
 
+#[allow(clippy::result_large_err)]
 pub fn parse_program_v4_subcommand(
     matches: &ArgMatches<'_>,
     default_signer: &DefaultSigner,