Loaded program test robustness#59
Merged
bw-solana merged 3 commits intoanza-xyz:masterfrom Mar 13, 2024
Merged
Conversation
Author
bw-solana
force-pushed
the
loaded_program_test_robustness
branch
from
0944a75 to
3fad744
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #59 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 837 837
Lines 225922 225873 -49
=========================================
- Hits 184955 184878 -77
- Misses 40967 40995 +28 |
|
Thanks for improving the tests!
Correct, the tombstone type is irrelevant for eviction, so this seems fine. |
alessandrod
approved these changes
Mar 13, 2024
codebender828
pushed a commit
to codebender828/agave
that referenced
this pull request
Oct 3, 2024
* tests robust to prog entry count
OliverNChalk
pushed a commit
to OliverNChalk/agave
that referenced
this pull request
Nov 11, 2025
* add cli arg generator_types * Use strum for BlockGeneratorOption * remove unnecessary lazy_static Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com> Signed-off-by: kirill lykov <lykov.kirill@gmail.com> * Simplify generator_type cli arg handling Co-authored-by: Illia Bobyr <ilya.bobyr@gmail.com> Signed-off-by: kirill lykov <lykov.kirill@gmail.com> * add expect --------- Signed-off-by: kirill lykov <lykov.kirill@gmail.com> Signed-off-by: kirill lykov <kirill.lykov@solana.com> Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com> Co-authored-by: Illia Bobyr <ilya.bobyr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some of the current tests in
loaded_programs.rsare not robust to differentMAX_LOADED_ENTRY_COUNTvalues. For context, I'm exploring tuning this value down for stress testing as a means of increasing cache churn.Summary of Changes
program_deploy_test_helperhelper function to reduce duplicate code. Note that a side effect of this is that we use the same reason for tombstones across all the programs. Previously they were different for each program, but my understanding is stressing this is not the intention of the test (and if it is, it wasn't comprehensive anyhow)