Start test validator bound to localhost by default (rather than all interfaces)#5862
Merged
alexpyattaev merged 1 commit intoApr 23, 2025
Merged
Conversation
a12cb91 to
e9b1b87
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #5862 +/- ##
=========================================
- Coverage 82.9% 82.9% -0.1%
=========================================
Files 830 830
Lines 377199 377199
=========================================
- Hits 312917 312895 -22
- Misses 64282 64304 +22 🚀 New features to boost your workflow:
|
gregcusack
reviewed
Apr 18, 2025
gregcusack
left a comment
There was a problem hiding this comment.
looks mostly good. you may have to rebase this once #5855 is merged. also would delete the extra line added after parsing bind_address
d5a5b4d to
d9193e8
Compare
d9193e8 to
a781797
Compare
Author
|
Rebased, now its pretty trivial. |
lijunwangs
approved these changes
Apr 22, 2025
|
Apologies for the fly-by review, but is this a breaking change? If so, can you add an entry to the changelog about this new behavior and how to restore the old behavior if needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Summary of Changes
Context
#5802 tried to do the same but was poorly scoped and as a result had a problematic change which made it possible to get binding of ports on top of already bound ones.
This resulted in #5856 to revert, but RCA there was not correct (test-validator binding had nothing to do with the issues there).
The logic changes to cluster-info moved into separate PR #5832