Add a sanity assert for stored_size at index generation time.#5804
Merged
HaoranYi merged 3 commits intoanza-xyz:masterfrom Jul 1, 2025
Merged
Conversation
HaoranYi
force-pushed
the
assert_store_alive_size_at_index_gen
branch
4 times, most recently
from
77c3e85 to
e688d99
Compare
HaoranYi
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5804 +/- ##
=========================================
- Coverage 83.3% 83.3% -0.1%
=========================================
Files 853 853
Lines 378185 378184 -1
=========================================
- Hits 315297 315296 -1
Misses 62888 62888 🚀 New features to boost your workflow:
|
HaoranYi
force-pushed
the
assert_store_alive_size_at_index_gen
branch
from
d9f1e29 to
31df760
Compare
Co-authored-by: Brooks <brooks@prumo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We have recently fixed a bug related to stored_size in #5778.
In the review comments, we discussed that it would be useful to add a sanity check for the "alive accounts size".
#5778 (review)
Summary of Changes
Add a sanity assert for
stored_sizeat index generation time.Fixes #