v2.2: Fixes storage alive size with secondary indexes (backport of #5778)

[mergify]

Problem

When generating the index with secondary indexes, the AccountStorageEntry's alive bytes is incorrectly set (approximately double). This likely causes issues later, e.g. not shrinking when they should.

Summary of Changes

Fix it.

Justification to Backport

The alive bytes is used to determine which storages to shrink, and when. Having the wrong value is a bug and makes debugging/reasoning about behavior harder.

---

This is an automatic backport of pull request #5778 done by [Mergify](https://mergify.com).

[mergify]

Cherry-pick of 679ad80 has failed:

On branch mergify/bp/v2.2/pr-5778
Your branch is up to date with 'origin/v2.2'.

You are currently cherry-picking commit 679ad8034.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   accounts-db/src/accounts_db/tests.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   accounts-db/src/accounts_db.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[HaoranYi]

lgtm

[t-nelson]

this won't have much bake time on testnet before 2.2 hits mb. we're confident?

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.4%. Comparing base (52fbd17) to head (f13d78e).
⚠️ Report is 72 commits behind head on v2.2.

Additional details and impacted files

@@           Coverage Diff           @@
##             v2.2    #5793   +/-   ##
=======================================
  Coverage    83.4%    83.4%           
=======================================
  Files         806      806           
  Lines      373256   373276   +20     
=======================================
+ Hits       311314   311381   +67     
+ Misses      61942    61895   -47     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[brooksprumo]

this won't have much bake time on testnet before 2.2 hits mb. we're confident?

I feel good, yes. I also spun up a v2.2 node with secondary indexes to confirm.

There's three sections in this graph: Left, Middle, and Right.

• Left: v2.2.8, no secondary indexes.
• Middle: v2.2.8, yes secondary indexes.
• Right: This PR, yes secondary indexes.

We can see the percentage alive in the storages is wrong (200%) in the middle with secondary indexes, and then correct again with this PR.

[jeffwashington]

lgtm

[mircea-c]

@mergify rebase

[mergify]

rebase

❌ Unable to rebase: user mircea-c is unknown.

Details

Please make sure mircea-c has logged in Mergify dashboard.

[brooksprumo]

@mircea-c Why the rebase?

[mircea-c]

@brooksprumo don't mind me. Just getting the hang of this. I thought it needed a rebase based on the github message, but it has no conflicts so can just be merged.

[brooksprumo]

@brooksprumo don't mind me. Just getting the hang of this. I thought it needed a rebase based on the github message, but it has no conflicts so can just be merged.

Gotcha. Yeah, please avoid rebasing PRs. I think it's best to let the owner/assignee be responsible for any rebasing; so as to avoid going through a long CI cycle unnecessarily.