Uses scan_accounts() while generating the secondary indexes#5779
Merged
brooksprumo merged 1 commit intoApr 14, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5779 +/- ##
=========================================
- Coverage 83.0% 82.9% -0.1%
=========================================
Files 826 826
Lines 375839 375836 -3
=========================================
- Hits 311955 311890 -65
- Misses 63884 63946 +62 🚀 New features to boost your workflow:
|
af9cfe4 to
4dea142
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When generating secondary account indexes, we scan storages and pass each account to
update_secondary_indexes(). This function needs a pubkey and aReadableAccountper account in the storage, but currently we load/pass around the whole StoredAccountMeta. This struct should be avoided when possible, as it contains AppendVec file format implementation details. And since we don't need any of those file format details, we should use a different function for scanning the storages.Summary of Changes
Uses scan_accounts() while generating the secondary indexes.