Skip to content

Consolidate and cleanup clippy configuration#5710

Merged
steviez merged 1 commit intoanza-xyz:masterfrom
steviez:consolidate_clippy_toml
Apr 8, 2025
Merged

Consolidate and cleanup clippy configuration#5710
steviez merged 1 commit intoanza-xyz:masterfrom
steviez:consolidate_clippy_toml

Conversation

@steviez
Copy link
Copy Markdown

@steviez steviez commented Apr 8, 2025

Problem

#5673 added clippy.toml when we already had .clippy.toml. The new file was getting automatically ignored:

warning: using config file `/.../solana/.clippy.toml`, `/.../solana/clippy.toml` will be ignored

and contained invalid lint configuration:

error: error reading Clippy's configuration file: unknown field `deny-attributes`, expected one of
...

Summary of Changes

  • Move invalid config in clippy.toml to Cargo.toml
  • Move contents of .clippy.toml to clippy.toml

- Move invalid config in clippy.toml to Cargo.toml
- Move contents of .clippy.toml to clippy.toml
@steviez steviez requested a review from alessandrod April 8, 2025 19:56
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.3%. Comparing base (c64126f) to head (8ef0328).
⚠️ Report is 3659 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5710   +/-   ##
=======================================
  Coverage    83.3%    83.3%           
=======================================
  Files         824      824           
  Lines      373748   373748           
=======================================
+ Hits       311538   311549   +11     
+ Misses      62210    62199   -11     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@steviez steviez merged commit cc3975a into anza-xyz:master Apr 8, 2025
41 checks passed
@steviez steviez deleted the consolidate_clippy_toml branch April 8, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants