Skip to content

v2.2: Bump solana-vote-interface to v2.2.3 (backport of #5579)#5590

Merged
jstarry merged 3 commits intov2.2from
mergify/bp/v2.2/pr-5579
Apr 2, 2025
Merged

v2.2: Bump solana-vote-interface to v2.2.3 (backport of #5579)#5590
jstarry merged 3 commits intov2.2from
mergify/bp/v2.2/pr-5579

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented Mar 31, 2025

Problem

Firedancer's fuzzing framework has to special case handling of VoteState::lockout because it is allowed to overflow. This can't happen on a normal cluster.

Summary of Changes

Bring in a fix for solana-vote-interface which prevents VoteState::lockout from overflowing: anza-xyz/solana-sdk#92

Fixes #


This is an automatic backport of pull request #5579 done by [Mergify](https://mergify.com).

(cherry picked from commit 135d3f8)

# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	programs/sbf/Cargo.lock
#	svm/examples/Cargo.lock
@mergify mergify Bot added the conflicts label Mar 31, 2025
@mergify mergify Bot requested a review from a team as a code owner March 31, 2025 21:42
@mergify
Copy link
Copy Markdown
Author

mergify Bot commented Mar 31, 2025

Cherry-pick of 135d3f8 has failed:

On branch mergify/bp/v2.2/pr-5579
Your branch is up to date with 'origin/v2.2'.

You are currently cherry-picking commit 135d3f8e3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   Cargo.lock
	both modified:   Cargo.toml
	both modified:   programs/sbf/Cargo.lock
	both modified:   svm/examples/Cargo.lock

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@jstarry jstarry requested a review from AshwinSekar March 31, 2025 21:53
@mergify
Copy link
Copy Markdown
Author

mergify Bot commented Mar 31, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@jstarry
Copy link
Copy Markdown

jstarry commented Mar 31, 2025

This version bump brings in the following sdk changes:

The main motivation for the version bump is the change in anza-xyz/solana-sdk#92 as described in the PR description. The other changes are low risk.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.3%. Comparing base (e65aa33) to head (fc6ae9c).

Additional details and impacted files
@@           Coverage Diff           @@
##             v2.2    #5590   +/-   ##
=======================================
  Coverage    83.3%    83.3%           
=======================================
  Files         805      805           
  Lines      371684   371683    -1     
=======================================
+ Hits       309948   309982   +34     
+ Misses      61736    61701   -35     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jstarry jstarry merged commit c092714 into v2.2 Apr 2, 2025
46 checks passed
@jstarry jstarry deleted the mergify/bp/v2.2/pr-5579 branch April 2, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants