Add agave-reserved-account-keys crate#5513
Conversation
e76fdbc to
9368db6
Compare
9368db6 to
2858041
Compare
|
Won't be able to merge this until the owner of this new crate is transferred to anza-team |
joncinque
left a comment
There was a problem hiding this comment.
Looks great! I followed along all of the usages and confirm that this covers all of them. Thankfully the only export from the crate is ReservedAccountKeys.
I also mostly skimmed the code copied from solana-reserved-account-keys.
@yihau can you accept ownership of agave-reserved-account-keys?
Actually I think we should ignore the crates check error and merge this once the rest of CI is green. Merging will allow us to prep the feature set migration change while we wait for the ownership transfer is completed. The crates check will only error on PR's that directly modify the specific Cargo.toml file so it shouldn't disrupt other devs. |
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5513 +/- ##
========================================
Coverage 83.3% 83.3%
========================================
Files 822 823 +1
Lines 372278 372392 +114
========================================
+ Hits 310348 310474 +126
+ Misses 61930 61918 -12 🚀 New features to boost your workflow:
|
(cherry picked from commit df2d3d8) # Conflicts: # Cargo.lock # Cargo.toml # core/Cargo.toml # core/src/banking_stage/unprocessed_packet_batches.rs # ledger/Cargo.toml # programs/sbf/Cargo.lock # svm/examples/Cargo.lock
|
Ownership has been transferred! https://crates.io/crates/agave-reserved-account-keys |
Problem
Reserved account key set composition is subject to runtime feature gates and should live in the agave monorepo rather than creating a circular dependency between agave and the sdk repos.
Summary of Changes
solana-reserved-account-keysagave-reserved-account-keyssolana-reserved-account-keysandsolana-sdk::solana-reserved-account-keysto `agave-reserved-account-keysFixes #