Skip to content

Add agave-reserved-account-keys crate#5513

Merged
jstarry merged 1 commit intoanza-xyz:masterfrom
jstarry:agave-reserved-account-keys
Mar 26, 2025
Merged

Add agave-reserved-account-keys crate#5513
jstarry merged 1 commit intoanza-xyz:masterfrom
jstarry:agave-reserved-account-keys

Conversation

@jstarry
Copy link
Copy Markdown

@jstarry jstarry commented Mar 26, 2025

Problem

Reserved account key set composition is subject to runtime feature gates and should live in the agave monorepo rather than creating a circular dependency between agave and the sdk repos.

Summary of Changes

  • Copy in solana-reserved-account-keys
  • Rename to agave-reserved-account-keys
  • Update usages of solana-reserved-account-keys and solana-sdk::solana-reserved-account-keys to `agave-reserved-account-keys

Fixes #

@jstarry jstarry requested review from a team as code owners March 26, 2025 20:41
@mergify
Copy link
Copy Markdown

mergify Bot commented Mar 26, 2025

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/web3.js (example)

Thank you for keeping the RPC clients in sync with the server API @jstarry.

@jstarry jstarry force-pushed the agave-reserved-account-keys branch 2 times, most recently from e76fdbc to 9368db6 Compare March 26, 2025 20:48
@jstarry jstarry force-pushed the agave-reserved-account-keys branch from 9368db6 to 2858041 Compare March 26, 2025 20:49
@jstarry jstarry requested review from joncinque and t-nelson March 26, 2025 20:49
@jstarry
Copy link
Copy Markdown
Author

jstarry commented Mar 26, 2025

Won't be able to merge this until the owner of this new crate is transferred to anza-team

Copy link
Copy Markdown

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I followed along all of the usages and confirm that this covers all of them. Thankfully the only export from the crate is ReservedAccountKeys.

I also mostly skimmed the code copied from solana-reserved-account-keys.

@yihau can you accept ownership of agave-reserved-account-keys?

@jstarry
Copy link
Copy Markdown
Author

jstarry commented Mar 26, 2025

Won't be able to merge this until the owner of this new crate is transferred to anza-team

Actually I think we should ignore the crates check error and merge this once the rest of CI is green. Merging will allow us to prep the feature set migration change while we wait for the ownership transfer is completed. The crates check will only error on PR's that directly modify the specific Cargo.toml file so it shouldn't disrupt other devs.

@jstarry jstarry added the v2.2 label Mar 26, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented Mar 26, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 94.73684% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.3%. Comparing base (381a5d5) to head (2858041).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #5513    +/-   ##
========================================
  Coverage    83.3%    83.3%            
========================================
  Files         822      823     +1     
  Lines      372278   372392   +114     
========================================
+ Hits       310348   310474   +126     
+ Misses      61930    61918    -12     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jstarry jstarry merged commit df2d3d8 into anza-xyz:master Mar 26, 2025
58 of 59 checks passed
@jstarry jstarry deleted the agave-reserved-account-keys branch March 26, 2025 22:25
mergify Bot pushed a commit that referenced this pull request Mar 26, 2025
(cherry picked from commit df2d3d8)

# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	core/Cargo.toml
#	core/src/banking_stage/unprocessed_packet_batches.rs
#	ledger/Cargo.toml
#	programs/sbf/Cargo.lock
#	svm/examples/Cargo.lock
@jstarry
Copy link
Copy Markdown
Author

jstarry commented Mar 27, 2025

Ownership has been transferred! https://crates.io/crates/agave-reserved-account-keys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants