Skip to content

Move vote processing loop to VoteWorker#5467

Merged
apfitzge merged 1 commit intoanza-xyz:masterfrom
apfitzge:simplify_vote_threads
Mar 26, 2025
Merged

Move vote processing loop to VoteWorker#5467
apfitzge merged 1 commit intoanza-xyz:masterfrom
apfitzge:simplify_vote_threads

Conversation

@apfitzge
Copy link
Copy Markdown

Problem

Summary of Changes

  • First step in plan: Move vote processing loop to separate file - vote_worker.rs

@apfitzge apfitzge mentioned this pull request Mar 25, 2025
8 tasks
@apfitzge apfitzge requested a review from jstarry March 25, 2025 15:27
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 25, 2025

Codecov Report

❌ Patch coverage is 93.10345% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.4%. Comparing base (bb5dbb3) to head (97b4b7a).
⚠️ Report is 3854 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5467   +/-   ##
=======================================
  Coverage    83.3%    83.4%           
=======================================
  Files         821      822    +1     
  Lines      372155   372169   +14     
=======================================
+ Hits       310327   310414   +87     
+ Misses      61828    61755   -73     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apfitzge apfitzge merged commit 873020b into anza-xyz:master Mar 26, 2025
47 checks passed
@apfitzge apfitzge deleted the simplify_vote_threads branch March 26, 2025 15:46
OliverNChalk pushed a commit to OliverNChalk/agave that referenced this pull request Nov 11, 2025
Originally written by Brennan <brennan.watt@solana.com> on Tue May 30
19:58:18 2023 -0700.

Rewritten to match the upstream scheduler code as of anza-xyz#5467 by Illia
Bobyr <illia.bobyr@anza.xyz>.

Previous version:

    commit 5464a7577680d7b4354d3bdbdbcbe89a4092460c
    Author: Brennan <brennan.watt@solana.com>
    Date:   Tue May 30 19:58:18 2023 -0700

        Replay invalidator2 (anza-xyz#36)

        * Add replay invalidator scaffolding upstream (solana-labs#31567)

        * Port invalidator code

        `RuntimeTransaction` updates added later by Illia Bobyr
        <illia.bobyr@anza.xyz>.
OliverNChalk pushed a commit to OliverNChalk/agave that referenced this pull request Nov 11, 2025
Originally written by Andrew Fitzgerald <apfitzge@gmail.com> on Wed Aug
9 14:57:55 2023 -0700.

Previous version:

    commit 86a2b8f8aa19e606bd6396dfdbc6f35950b23ee9
    Author: Andrew Fitzgerald <apfitzge@gmail.com>
    Date:   Wed Aug 9 14:57:55 2023 -0700

        Spawn adversarial and normal banking stages (anza-xyz#113)

Rewritten to match the upstream scheduler code as of anza-xyz#5467 by Illia
Bobyr <illia.bobyr@anza.xyz>.

This change includes all of the following changes:

---

Author: Illia Bobyr <illia.bobyr@solana.com>
Date:   Mon Oct 2 14:03:46 2023 -0700

    adversary: test_scheduler => attack_scheduler (anza-xyz#175)

    We mostly talk about attacks, when we discuss the functionality this
    code supports.  Considering that we have a lot of other kinds of tests,
    it seems a bit clearer to call use "attack" in this part of the code.

Author: Illia Bobyr <illia.bobyr@solana.com>
Date:   Tue Oct 3 15:21:33 2023 -0700

    adversary: test_generators => transaction_generators (anza-xyz#178)

    We mostly talk about "attacks" rather than "tests" in this part of the
    code.  And even the main type in the `test_generators` module is called
    `TransactionGenerator`.

Author: kirill lykov <kirill.lykov@solana.com>
Date:   Thu Feb 8 10:52:48 2024 +0100

    replay: atomicbool instead of singleton for dropping packets (anza-xyz#224)

    * use atomicbool instead of singleton to drop packets

    * add use for Ordering

    Co-authored-by: Illia Bobyr <ilya.bobyr@gmail.com>
    Signed-off-by: kirill lykov <lykov.kirill@gmail.com>

    * rename drop_packets

    ---------

    Signed-off-by: kirill lykov <lykov.kirill@gmail.com>
    Co-authored-by: Illia Bobyr <ilya.bobyr@gmail.com>

Author: Brennan <brennan.watt@anza.xyz>
Date:   Fri Mar 22 06:45:29 2024 -0700

    remove dead code (anza-xyz#298)

Author: Andrew Fitzgerald <apfitzge@gmail.com>
Date:   Tue Jul 16 14:49:59 2024 -0500

    AdversarialBankingStage: Remove warning (anza-xyz#370)

    Remove warning. Adjust names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants