Skip to content

Test cargo-build-sbf in CI#5277

Merged
LucasSte merged 5 commits intoanza-xyz:masterfrom
LucasSte:build-sbf-ci
Mar 24, 2025
Merged

Test cargo-build-sbf in CI#5277
LucasSte merged 5 commits intoanza-xyz:masterfrom
LucasSte:build-sbf-ci

Conversation

@LucasSte
Copy link
Copy Markdown

@LucasSte LucasSte commented Mar 13, 2025

Problem

There was a regression with cargo-build-sbf fixed in #5267 that went undetected because #1581 removed integration tests with cargo-build-sbf.

Summary of Changes

The stable-sbf job now runs sanity tests for cargo-build-sbf.

@LucasSte LucasSte requested a review from Lichtso March 13, 2025 20:04
@LucasSte LucasSte marked this pull request as ready for review March 13, 2025 20:04
Comment thread ci/test-stable.sh Outdated
@LucasSte LucasSte force-pushed the build-sbf-ci branch 5 times, most recently from 5047506 to eafd0f4 Compare March 14, 2025 21:26
@LucasSte LucasSte marked this pull request as draft March 15, 2025 00:26
@LucasSte LucasSte force-pushed the build-sbf-ci branch 2 times, most recently from 5a66b0c to 1d43766 Compare March 21, 2025 22:29
@LucasSte LucasSte force-pushed the build-sbf-ci branch 4 times, most recently from 6d7899a to 0356674 Compare March 24, 2025 15:12
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.3%. Comparing base (39911bb) to head (b5e36c8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #5277     +/-   ##
=========================================
- Coverage    83.3%    83.3%   -0.1%     
=========================================
  Files         820      820             
  Lines      371750   371750             
=========================================
- Hits       310025   309963     -62     
- Misses      61725    61787     +62     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LucasSte LucasSte requested a review from Lichtso March 24, 2025 17:10
@LucasSte LucasSte marked this pull request as ready for review March 24, 2025 17:10
@Lichtso
Copy link
Copy Markdown

Lichtso commented Mar 24, 2025

This more than doubles the time spent in buildkite/agave/stable-sbf

@LucasSte
Copy link
Copy Markdown
Author

This more than doubles the time spent in buildkite/agave/stable-sbf

I'll avoid rebuilding the x86 test binaries, but cargo-build-sbf needs a place in the CI, so tests times will increase.

@LucasSte LucasSte merged commit fcb168e into anza-xyz:master Mar 24, 2025
59 checks passed
@LucasSte LucasSte deleted the build-sbf-ci branch March 24, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants