Test cargo-build-sbf in CI#5277
Merged
LucasSte merged 5 commits intoanza-xyz:masterfrom Mar 24, 2025
Merged
Conversation
Lichtso
reviewed
Mar 14, 2025
5047506 to
eafd0f4
Compare
5a66b0c to
1d43766
Compare
6d7899a to
0356674
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5277 +/- ##
=========================================
- Coverage 83.3% 83.3% -0.1%
=========================================
Files 820 820
Lines 371750 371750
=========================================
- Hits 310025 309963 -62
- Misses 61725 61787 +62 🚀 New features to boost your workflow:
|
|
This more than doubles the time spent in buildkite/agave/stable-sbf |
Author
I'll avoid rebuilding the x86 test binaries, but |
Lichtso
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There was a regression with
cargo-build-sbffixed in #5267 that went undetected because #1581 removed integration tests withcargo-build-sbf.Summary of Changes
The
stable-sbfjob now runs sanity tests forcargo-build-sbf.