v2.2: Bump platform tools version (backport of #5267)#5275
Merged
Conversation
Author
|
Cherry-pick of 36d706c has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
0e74422 to
c8c9a6b
Compare
Lichtso
approved these changes
Mar 13, 2025
t-nelson
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Platform tools version v1.44 caused a regression on the build pipeline used in
cargo-build-sbf, whereby thellvm-objcopycommand run after the build would create invalid binary file for our ELF loader.This problem was undetected because #1581 removed all integration tests with
cargo-build-sbf. Since it was merged, we do not build and test any program withcargo-build-sbfin the CI.Summary of Changes
The new version fixes the issue and reduces program size for SBPFv2 and SBPFv3.
PS: I'll add sanity tests for
cargo-build-sbfto the CI in a follow up PR.This is an automatic backport of pull request #5267 done by [Mergify](https://mergify.com).