Skip to content

Feature cleanup - Reward full priority fee to validators #22#4959

Merged
tao-stones merged 1 commit intoanza-xyz:masterfrom
tao-stones:refactor-cleanup-activated-feature-code-reward_full_priority_fee
Feb 14, 2025
Merged

Feature cleanup - Reward full priority fee to validators #22#4959
tao-stones merged 1 commit intoanza-xyz:masterfrom
tao-stones:refactor-cleanup-activated-feature-code-reward_full_priority_fee

Conversation

@tao-stones
Copy link
Copy Markdown

Problem

Feature gate 3opE3EzAKnUftUDURkzMgwpNgimBAypW1mNDYH4x4Zg7: Reward full priority fee to validators #22 is activated everywhere.

./solana feature status 3opE3EzAKnUftUDURkzMgwpNgimBAypW1mNDYH4x4Zg7 -ut
Feature                                      | Status                  | Activation Slot | Description
3opE3EzAKnUftUDURkzMgwpNgimBAypW1mNDYH4x4Zg7 | active since epoch 744  | 315884256       | Reward full priority fee to validators #34731

./solana feature status 3opE3EzAKnUftUDURkzMgwpNgimBAypW1mNDYH4x4Zg7 -ud
Feature                                      | Status                  | Activation Slot | Description
3opE3EzAKnUftUDURkzMgwpNgimBAypW1mNDYH4x4Zg7 | active since epoch 805  | 347760000       | Reward full priority fee to validators #34731

./solana feature status 3opE3EzAKnUftUDURkzMgwpNgimBAypW1mNDYH4x4Zg7 -um
Feature                                      | Status                  | Activation Slot | Description
3opE3EzAKnUftUDURkzMgwpNgimBAypW1mNDYH4x4Zg7 | active since epoch 741  | 320112000       | Reward full priority fee to validators #34731

Summary of Changes

  • remove feature specific code.

Fixes #

…tivated

everywhere. Remove feature specific code.
}
}

#[test]
Copy link
Copy Markdown
Author

@tao-stones tao-stones Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For removed tests, there are corresponding tests for test_distribute_transaction_fee_details_* version

Comment thread runtime/src/bank/tests.rs
);
}

#[test]
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_filter_program_errors_and_collect_fee_details covers these two removed tests.

Comment thread runtime/src/bank.rs
self.collector_fees.fetch_add(fees, Relaxed);
}

// Note: this function is not yet used; next PR will call it behind a feature gate
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment could be removed

@tao-stones tao-stones merged commit 2c4a557 into anza-xyz:master Feb 14, 2025
@tao-stones tao-stones deleted the refactor-cleanup-activated-feature-code-reward_full_priority_fee branch February 14, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants