Recreate connection cache after restart#4841
Merged
lijunwangs merged 6 commits intoanza-xyz:masterfrom Feb 11, 2025
Merged
Conversation
alexpyattaev
reviewed
Feb 8, 2025
| validator_config.staked_nodes_overrides = Arc::new(RwLock::new(overrides)); | ||
| } | ||
|
|
||
| assert!( |
Author
There was a problem hiding this comment.
This assert is useless as the branch condition already cover it.
Author
There was a problem hiding this comment.
see "if config.tpu_use_quic"
alexpyattaev
reviewed
Feb 8, 2025
|
I guess would be nice to explain in PR description which test was slowed down in case we need to later search for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The connection cache might hold connections to the validators before the restart which can make the test slow as it has to wait for the existing defunct connection to timeout.
The tests under local-cluster/tests can all be impacted if it involved restart. For example
cargo test test_snapshots_restart_validity
This is exposed when we tried to increase the QUIC connection idle timeout value for example to 60 seconds.
Summary of Changes
Recreate the connection cache after a restart.
Fixes #