rpc: Remove deprecated helper function#4818
Merged
steviez merged 1 commit intoanza-xyz:masterfrom Feb 6, 2025
Merged
Conversation
getConfirmedSignaturesForAddress was removed in v2.0. This changes removes get_confirmed_signatures_for_address(), which was a helper function for that RPC method. This was seemingly just missed in the commit that removed the deprecated functions
steveluscher
approved these changes
Feb 6, 2025
steveluscher
left a comment
There was a problem hiding this comment.
This is still a method in @solana/web3.js@1 but it no longer relies on calling this puppy. It emulates it.
t-nelson
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
getConfirmedSignaturesForAddress was removed in v2.0. This changes removes get_confirmed_signatures_for_address(), which was a helper function for that RPC method. This was seemingly just missed in the commit that removed the deprecated functions
In #1809, we can see that the only caller of this function was removed.
clippyprobably just missed this function as unused due topub:https://github.com/anza-xyz/agave/pull/1809/files#diff-b55d9bcb5d2e7eae09fd352edcc765f9c2a4c05b97e9847582071d35850e8671L4735-L4762