Feature - loader-v2 and loader-v3 deprecation warnings#4704
Conversation
41af157 to
62736b6
Compare
62736b6 to
2279bc0
Compare
2279bc0 to
e917644
Compare
KirillLykov
left a comment
There was a problem hiding this comment.
maybe also add somewhere (to documentation of loader-v3 or loader-v4 an example of using v4 in comparison to the previous one. For example, --program-id cla has changed the semantics and --fee-payer is removed. So an example could say that a typical deployment command line with version 3 was ... while now it is ....
|
I will do follow up PRs for the docs, also to fix the bug you discovered in the signer aliasing. |
joncinque
left a comment
There was a problem hiding this comment.
A bit late to the party, but this looks great, thanks!
attempting to deploy on them will already fail on a test validator with a genesis feature set including disable_new_loader_v3_deployments by default
This is a very important point. Can you add that behavior as a breaking change to the CHANGELOG in solana-test-validator, along with what command should be used instead, and an example command of how to disable the feature if needed?
We also need to make devrel / Anchor aware of this breaking change in v2.2.
|
Instead of introducing a sub command, why not just abstract out the work behind the scenes in |
Problem
Loader-v2 (see #4487 (comment)) and loader-v3 (see #4666) are deprecated and attempting to deploy on them will already fail on a test validator with a genesis feature set including
disable_new_loader_v3_deploymentsby default. Thus, there should be a warning telling dApp devs what to do instead of just seeing:Summary of Changes
Adds deprecation warnings in the SDK and the CLI.
Removes the outdated and unused test program "rust/finalize".