Write default hash to account storage#469
Merged
HaoranYi merged 4 commits intoanza-xyz:masterfrom Apr 16, 2024
Merged
Conversation
HaoranYi
force-pushed
the
account_hash/default_hash
branch
2 times, most recently
from
8ea3f0d to
e1947f3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #469 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 851 851
Lines 231714 231712 -2
=======================================
+ Hits 189649 189663 +14
+ Misses 42065 42049 -16 |
HaoranYi
force-pushed
the
account_hash/default_hash
branch
from
e1947f3 to
f60cafa
Compare
HaoranYi
changed the title
Author
|
Now #519 has been merged. |
| ); | ||
| } else { | ||
| assert_eq!( | ||
| db.load_account_hash( |
There was a problem hiding this comment.
should we ever be saving/loading a hash now? not sure about this test.
Author
There was a problem hiding this comment.
I think the intention of this test is to test load hash from cache vs storage.
What this test does is to make sure that when we load from the write cache, we should have the correct hash (pass=0), but when we load from the storage, we should have default hash (pass=1).
HaoranYi
force-pushed
the
account_hash/default_hash
branch
from
f60cafa to
d889fde
Compare
brooksprumo
requested changes
Apr 16, 2024
michaelschem
pushed a commit
to michaelschem/agave
that referenced
this pull request
Apr 20, 2024
* write default hash to apendvec * fix get_pubkey_hash_for_slot * fix tests * fix rebase error --------- Co-authored-by: HaoranYi <haoran.yi@solana.com>
OliverNChalk
pushed a commit
to OliverNChalk/agave
that referenced
this pull request
Nov 11, 2025
* expose nonblocking clients from local-cluster * fix typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Storing default hash in account storage helps storage compression and saves snapshot storage.
Summary of Changes
Write default hash to account storage.
Note: This PR depends on #519 to be released. Once #519 is released. We can then merge this PR. For details, see the discussion here #476 (comment)
Fixes #