Skip to content

memory syscalls: improve test coverage and other review comments#4650

Closed
seanyoung wants to merge 4 commits intoanza-xyz:masterfrom
seanyoung:reverse-limits-2
Closed

memory syscalls: improve test coverage and other review comments#4650
seanyoung wants to merge 4 commits intoanza-xyz:masterfrom
seanyoung:reverse-limits-2

Conversation

@seanyoung
Copy link
Copy Markdown

Problem

Implement review comments from #4598

Summary of Changes

Fixes #

@mergify
Copy link
Copy Markdown

mergify Bot commented Jan 27, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@seanyoung seanyoung marked this pull request as ready for review January 29, 2025 13:22
@seanyoung seanyoung requested a review from a team as a code owner January 29, 2025 13:22
@mergify
Copy link
Copy Markdown

mergify Bot commented Feb 4, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@Lichtso
Copy link
Copy Markdown

Lichtso commented Aug 5, 2025

Support for cross memory region access was removed in #5871.

@Lichtso Lichtso closed this Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants