Add TowerVoteState#4618
Merged
Merged
Conversation
jstarry
force-pushed
the
refactor/tower-vote-state
branch
4 times, most recently
from
55435cb to
e878b07
Compare
jstarry
force-pushed
the
refactor/tower-vote-state
branch
2 times, most recently
from
cd6630e to
c4f0636
Compare
AshwinSekar
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
This looks correct although we use TowerVoteState we still end up converting back to VoteState1_14_11 for storage so migration of the tower file is not necessary.
@carllin do you mind double checking this commit just in case?
carllin
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tower attempts to use the latest version of the vote program's vote state for tracking vote updates but is actually only serialized with an old version of vote state. It should instead just use a simple vote state algorithm which is independent of vote program state changes.
Summary of Changes
Fixes #