quic: disable send fairness#4586
Merged
Merged
Conversation
alessandrod
approved these changes
Jan 22, 2025
lijunwangs
approved these changes
Jan 22, 2025
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
mergify Bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
(cherry picked from commit 1e721f0) # Conflicts: # quic-client/src/nonblocking/quic_client.rs # streamer/src/nonblocking/testing_utilities.rs # tpu-client-next/src/quic_networking.rs
alessandrod
pushed a commit
that referenced
this pull request
Jan 23, 2025
* quic: disable send fairness (#4586) (cherry picked from commit 1e721f0) # Conflicts: # quic-client/src/nonblocking/quic_client.rs # streamer/src/nonblocking/testing_utilities.rs # tpu-client-next/src/quic_networking.rs * resolve some merge conflicts --------- Co-authored-by: Emanuele Cesena <emanuele.cesena@gmail.com> Co-authored-by: Lijun Wang <83639177+lijunwangs@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
quinn-rs/quinn#2002 was implemented in Quinn but never activated in Agave.
Summary of Changes
Disable send fairness in Quic (transport config).