Use loader v3 instead of v2 in the SVM#454
Merged
LucasSte merged 1 commit intoanza-xyz:masterfrom Mar 27, 2024
Merged
Conversation
dmakarov
approved these changes
Mar 27, 2024
OliverNChalk
pushed a commit
to OliverNChalk/agave
that referenced
this pull request
Nov 11, 2025
It seems simpler to have two distinct generator templates: one for attacks that want to use the maximum possible number of accounts in a transaction, and another one that uses the maximum possible number of accounts of the maximum size. These two templates have constraints that are quite different, and it simplifies both the implementation and the interfaces of the templates. SQUASH: This change should be incorporated into the following changes: Brennan <brennan.watt@anza.xyz> Tue Sep 3 21:28:31 2024 -0700 constrain max accounts, shrink batch size (anza-xyz#419) Brennan <brennan.watt@anza.xyz> Thu Apr 18 18:10:43 2024 -0700 read max accounts attack (anza-xyz#327) Illia Bobyr <illia.bobyr@solana.com> Mon Oct 23 12:21:02 2023 -0700 Read and write lock attack (anza-xyz#196)
OliverNChalk
pushed a commit
to OliverNChalk/agave
that referenced
this pull request
Nov 11, 2025
Original names were not specific enough. "Max" in the name could refer
to the transaction size, account size, number of accounts or, possibly,
even more other things. And we already have a `max_accounts_tx`
template that indeed is about putting as many accounts into a
transaction - it is confusing that `read_max_accounts` and
`max_accounts_tx` are unrelated.
FIXUP: This change should be absorbed into the changes that touch
`read_max_accounts.rs` and `write_max_accounts.rs`:
```
❯ git log --format=%s agave/master..upstream/master -- core/src/banking_stage/adversary/transaction_generators/{read,write}_max_accounts.rs
SQUASH Split max_size_accounts_tx out of max_accounts_tx (anza-xyz#454)
constrain max accounts, shrink batch size (anza-xyz#419)
write max accounts test (anza-xyz#328)
read max accounts attack (anza-xyz#327)
Read and write lock attack (anza-xyz#196)
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
BPFLoader v1 and v2 are deprecated, but the integration tests were still using them. In addition, there were no guidance functions for deploying programs using the V3 standard, as described in #114.
Summary of Changes
I updated the test to use the loader V3 and created an example function to deploy programs.