removes branch to recover legacy shreds #4488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
force-pushed
the
rm-recover-legacy-shreds
branch
from
288bfc8 to
f62079f
Compare
behzadnouri
changed the title
behzadnouri
force-pushed
the
rm-recover-legacy-shreds
branch
3 times, most recently
from
78df153 to
f5b17dc
Compare
behzadnouri
force-pushed
the
rm-recover-legacy-shreds
branch
from
f5b17dc to
1b28913
Compare
carllin
previously approved these changes
Jan 19, 2025
Comment on lines
+1116
to
+1119
| debug_assert_matches!( | ||
| shred.common_header().shred_variant, | ||
| ShredVariant::MerkleCode { .. } | ShredVariant::MerkleData { .. } | ||
| ); |
There was a problem hiding this comment.
not really, just a minor sanity check.
I guess it should be fine since it is only "debug" assert.
behzadnouri
force-pushed
the
rm-recover-legacy-shreds
branch
from
1b28913 to
48d5cb2
Compare
Legacy shreds are discarded on all clusters: https://github.com/anza-xyz/agave/blob/91d0d0cae/ledger/src/shred.rs#L1275-L1277 Removing the branch to recover legacy shreds would allow to further simplify and optimize shreds recovery code.
behzadnouri
force-pushed
the
rm-recover-legacy-shreds
branch
from
48d5cb2 to
4b33a44
Compare
|
@carllin I had to rebase to resolve merge conflicts. |
carllin
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Legacy shreds are discarded on all clusters:
https://github.com/anza-xyz/agave/blob/91d0d0cae/ledger/src/shred.rs#L1275-L1277
Removing the branch to recover legacy shreds would allow to further simplify and optimize shreds recovery code.
Summary of Changes
The commit removes branch to recover legacy shreds.