Fix missing dependency in solana-curve25519's Cargo.toml

[hycinth22]

Problem

Currently, solana-curve25519 indirectly depends on crate subtle through curve25519-dalek.

here, solana-curve25519 uses into_option provided by crate subtle (provided in subtle >=2.6)

agave/curves/curve25519/src/scalar.rs

Line 22 in aaee37d

.into_option()

agave/curves/curve25519/src/scalar.rs

Line 38 in aaee37d

.into_option()

but dependency curve25519-dalek only require subtle version >=2.3. (https://docs.rs/crate/curve25519-dalek/4.1.3/source/Cargo.toml)

---

Currently, we specify subtle version 2.6.1 in agave workspace Cargo.toml.
That's why the compilation of validator can succeed.

agave/Cargo.toml

Line 640 in b6a3aa0

subtle = "2.6.1"

But there is no one in solana-curve25519's Cargo.toml

---

For users who only use the crate solana-curve25519,
this will cause Cargo to resolve the lower version of subtle and report into_option cannot be found.

Summary of Changes

Fixes # add it in solana-curve25519's Cargo.toml to fix potential compile error

[joncinque]

Thanks for your contribution! I confirm that this is an issue. Just a little nit to make it clear what's going on for future readers -- let me know what you think

[joncinque]

CI will also fail due to uncommitted Cargo.lock changes -- can you run ./scripts/cargo-for-all-lock-files.sh tree and commit those changes too?

[hycinth22]

updated 😀 thanks for reviewing

[joncinque]

We're almost there, I swear!

[hycinth22]

hope everything is fixed.

BTW, is there a way for me to check these rules next time I submit a PR?

[joncinque]

BTW, is there a way for me to check these rules next time I submit a PR?

To be honest, it's a bit annoying to do locally, which is why I didn't bring it up. But you can run ./ci/test-checks.sh and ./ci/test-sanity.sh if you have the required tools installed

[joncinque]

Thanks for your contribution!