Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add crate-check into mergify rules #3914

Merged
merged 1 commit into from
Dec 4, 2024
Merged

ci: add crate-check into mergify rules #3914

merged 1 commit into from
Dec 4, 2024

Conversation

yihau
Copy link
Member

@yihau yihau commented Dec 4, 2024 •
edited
Loading

Problem

steal Jon's credit #3910

Summary of Changes

this PR:
Screenshot 2024-12-04 at 21 52 50

  • rename check to crate check to avoid a name conflict.
  • add an "or" condition for PRs that do not trigger crate-check

Close #3910

@yihau yihau force-pushed the mergify-crate-check branch from 2d752b1 to c9df2fe Compare December 4, 2024 13:46
@yihau yihau force-pushed the mergify-crate-check branch from c9df2fe to 356d297 Compare December 4, 2024 13:48
@yihau yihau requested a review from joncinque December 4, 2024 13:54
joncinque
joncinque approved these changes Dec 4, 2024
View reviewed changes
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better than mine, thanks!

@yihau yihau merged commit b9089db into anza-xyz:master Dec 4, 2024
22 checks passed
@yihau yihau deleted the mergify-crate-check branch December 4, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncinque joncinque joncinque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihau @joncinque