[svm] add ed25519 and secp256r1 logic to precompile tests#3877
Merged
samkim-crypto merged 1 commit intoanza-xyz:masterfrom Dec 3, 2024
Merged
[svm] add ed25519 and secp256r1 logic to precompile tests#3877samkim-crypto merged 1 commit intoanza-xyz:masterfrom
samkim-crypto merged 1 commit intoanza-xyz:masterfrom
Conversation
LucasSte
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Secp256r1 precompile was added (#3152), but the precompile tests in svm does not include it.
Summary of Changes
I included secp256r1 in the precompile tests. I noticed that ed25519 precompile was also missing, so I added that too.
I also swapped out
randwith an olderrand0-7in the dev dependency to simplify the key generation a little, but I can revert this if suggested.Fixes #