[TieredStorage] Add TieredStorage::write_accounts_to_hot_storage() API#382
Closed
yhchiang-sol wants to merge 2 commits intoanza-xyz:masterfrom
Closed
[TieredStorage] Add TieredStorage::write_accounts_to_hot_storage() API#382yhchiang-sol wants to merge 2 commits intoanza-xyz:masterfrom
yhchiang-sol wants to merge 2 commits intoanza-xyz:masterfrom
Conversation
yhchiang-sol
force-pushed
the
ts-write-hot-accounts
branch
from
3dd7237 to
66c8caa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #382 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 838 838
Lines 227531 227588 +57
=======================================
+ Hits 186323 186376 +53
- Misses 41208 41212 +4 |
yhchiang-sol
force-pushed
the
ts-write-hot-accounts
branch
from
66c8caa to
9776171
Compare
yhchiang-sol
force-pushed
the
ts-write-hot-accounts
branch
from
9776171 to
7aa98bb
Compare
brooksprumo
reviewed
Mar 22, 2024
brooksprumo
left a comment
brooksprumo
left a comment
There was a problem hiding this comment.
I don't think this PR solves the leaky api issue.
| ) -> Option<Vec<StoredAccountInfo>> { | ||
| match self { | ||
| Self::AppendVec(av) => av.append_accounts(accounts, skip), | ||
| Self::TieredStorage(ts) => ts.write_accounts_to_hot_storage(accounts, skip).ok(), |
There was a problem hiding this comment.
IMO this is effectively the same as using the HOT_FORMAT constant. So API details are still leaking out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current TieredStorage::write_accounts() API requires a format parameter
to determine which format to use, but this design requires leaking TieredStorage
information to AccountsFile.
Summary of Changes
Instead of requiring AccountsFile to provide a format parameter, this PR adds
TieredStorage::write_accounts_to_hot_storage() API so that AccountsFile
doesn't need to know the detail format information to write accounts to a
hot storage.
Dependency
#72